Update to Ktor 3 #6214
Merged
Update to Ktor 3 #6214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for apollo-android-docs canceled.
|
Closed
martinbonnin
commented
Oct 22, 2024
martinbonnin
commented
Oct 23, 2024
| @@ -402,7 +402,6 @@ public final class com/apollographql/apollo/api/CompiledVariable { | |||
| public final class com/apollographql/apollo/api/CustomScalarAdapters : com/apollographql/apollo/api/ExecutionContext$Element { | |||
| public static final field Empty Lcom/apollographql/apollo/api/CustomScalarAdapters; | |||
| public static final field Key Lcom/apollographql/apollo/api/CustomScalarAdapters$Key; | |||
| public static final field PassThrough Lcom/apollographql/apollo/api/CustomScalarAdapters; | |||
There was a problem hiding this comment.
This is due to a BCV update
martinbonnin
commented
Oct 23, 2024
| final fun <get-entries>(): kotlin.enums/EnumEntries<com.apollographql.apollo.api.http/HttpMethod> // com.apollographql.apollo.api.http/HttpMethod.entries.<get-entries>|<get-entries>#static(){}[0] | ||
|
|
||
| final fun valueOf(kotlin/String): com.apollographql.apollo.api.http/HttpMethod // com.apollographql.apollo.api.http/HttpMethod.valueOf|valueOf#static(kotlin.String){}[0] | ||
| final fun values(): kotlin/Array<com.apollographql.apollo.api.http/HttpMethod> // com.apollographql.apollo.api.http/HttpMethod.values|values#static(){}[0] |
There was a problem hiding this comment.
The Klib API dump changed a lot. Not reporting upstream because Klib support is still experimental and I guess this is to be expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress as it requires a release of:
apollo-kotlin-mockserverapollo-kotlin-executionUpdate to Ktor3
This is technically a breaking change but standard use cases shouldn't be affected so I'm suggesting we release this as a minor version.
If you are using Apollo Kotlin in an Android app, your are not affected.
You are affected if:
You'll have to update your project to Ktor 3 when updating to Apollo Kotlin
4.1.0. Or you can start using the experimental websockets and exclude the Ktor transitive dependencies fromapollo-runtime-js.apollo-debug-server-jvm(Note:apollo-debug-server-androidis not impacted):You'll have to update your project to Ktor 3 when updating to Apollo Kotlin
4.1.0.com.apollographql.apollo:apollo-mockserver:MockServerhas moved to new coordinates in v4. The oldMockServerwas only kept as a redirect marker and is now removed. Usecom.apollographql.mockserver:apollo-mockserverinstead and replace all thecom.apollographql.apollo.mockserverwithcom.apollographql.mockserverin your project. Keep using versions0.0.xfor Ktor2 or update to0.1.xfor Ktor3.apollo-testing-support:Those helpers were never meant to be public and are removed. Copy/paste them in your project if needed.
Technical details
apollo-mockserveris removed from this repo. I contemplated keeping it to avoid a breaking change but the Ktor3 update is a breaking change anyway so I figured we might as well accept our loss here and move on.BothEdit: ultimately, the tombstone were removed because there is very little tooling to work with them.apollo-mockserverandapollo-ktor-engineare now Maven tombstones. They should publish a redirect marker on maven central. Never tried that but could be useful.The execution algorithms should probably move to this repo. This is a logical place to be. Plus it'll allow removing the external dependency for
apollo-debug-server-jvm.More generally,
apollo-debug-servershould have been marked experimental given it includes pre-release dependencies.More comments inline