Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tryfrom for HIR types for apollo_encoder types #424

Closed
lrlna opened this issue Jan 17, 2023 · 0 comments · Fixed by #466
Closed

tryfrom for HIR types for apollo_encoder types #424

lrlna opened this issue Jan 17, 2023 · 0 comments · Fixed by #466
Assignees
@goto-bus-stop
Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation apollo-encoder

Comments

@lrlna
Copy link
Member

lrlna commented Jan 17, 2023

similar to #278, it'd be good to be able to encode HIR types to apollo-encoder types in order to modify input strings. We should possibly hold off on implementation of this until after we decide on the design for #420.
@lrlna lrlna added apollo-encoder apollo-compiler issues/PRs pertaining to semantic analysis & validation labels Jan 17, 2023
zackangelo added a commit to zackangelo/apollo-rs that referenced this issue Mar 1, 2023
@zackangelo
add TryFrom impls to convert from hir to encoder types (apollographql…
1092fd4 
…#424)
@zackangelo zackangelo mentioned this issue Mar 1, 2023
Merged
lrlna pushed a commit to zackangelo/apollo-rs that referenced this issue Apr 24, 2023
@zackangelo @lrlna
add TryFrom impls to convert from hir to encoder types (apollographql…
1a4ed8d 
…#424)
lrlna pushed a commit that referenced this issue Apr 24, 2023
@zackangelo
feat(encoder): impl TryFrom<apollo_compiler::hir::*> for apollo_encod…
183ae48 
…er::* (#424) (#466)

---------
Co-authored-by: Irina Shestak <8107784+lrlna@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goto-bus-stop goto-bus-stop

Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation apollo-encoder
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add TryFrom impls to convert from hir to encoder types (#424) zackangelo/apollo-rs
2 participants
@goto-bus-stop @lrlna