Fix type of ApolloServerPluginUsageReporting reportTimer (#7799)

Fixes #7798 In src/plugin/usageReporting/plugin.ts reportTimer is typed as NodeJS.Timer, it is actually a timeout, so using node 18> types it is incompatible with clearInterval()
apollographql · Dec 11, 2023 · 63dc50f · 63dc50f
1 parent a7ecbba
commit 63dc50f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/fair-squids-unite.md b/.changeset/fair-squids-unite.md
@@ -0,0 +1,5 @@
+---
+'@apollo/server': patch
+---
+
+Fix type of ApolloServerPluginUsageReporting reportTimer
diff --git a/packages/server/src/plugin/usageReporting/plugin.ts b/packages/server/src/plugin/usageReporting/plugin.ts
@@ -206,7 +206,7 @@ export function ApolloServerPluginUsageReporting<TContext extends BaseContext>(
           }
         | undefined;
 
-      let reportTimer: NodeJS.Timer | undefined;
+      let reportTimer: NodeJS.Timeout | undefined;
       if (!sendReportsImmediately) {
         reportTimer = setInterval(
           () => sendAllReportsAndReportErrors(),