Skip to content

Commit

Permalink
Switch ApolloServerBase.schema from private access to protected access (
Browse files Browse the repository at this point in the history
  • Loading branch information
vincenzo authored and martijnwalraven committed Sep 5, 2018
1 parent 4a40976 commit 88417b7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ All of the packages in the `apollo-server` repo are released with the same versi
- Update `graphql-playground-html` to 1.7.4 [#1586](https://github.com/apollographql/apollo-server/pull/1586)
- Add support for `graphql-js` v14 by augmenting typeDefs with the `@cacheControl` directive so SDL validation doesn't fail [#1595](https://github.com/apollographql/apollo-server/pull/1595)
- Add `node-fetch` extensions typing to `RequestInit` [#1602](https://github.com/apollographql/apollo-server/pull/1602)
- Switch `ApolloServerBase.schema` from private access to protected access. [#1610](https://github.com/apollographql/apollo-server/pull/1610)
- Add toggle for including error messages in reports [#1615](https://github.com/apollographql/apollo-server/pull/1615)
- Fix `apollo-server-cloud-functions` tests [#1611](https://github.com/apollographql/apollo-server/pull/1611/)

Expand Down
3 changes: 2 additions & 1 deletion packages/apollo-server-core/src/ApolloServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,11 @@ export class ApolloServerBase {
public graphqlPath: string = '/graphql';
public requestOptions: Partial<GraphQLOptions<any>>;

private schema: GraphQLSchema;
private context?: Context | ContextFunction;
private engineReportingAgent?: EngineReportingAgent;
private extensions: Array<() => GraphQLExtension>;

protected schema: GraphQLSchema;
protected subscriptionServerOptions?: SubscriptionServerOptions;
protected uploadsConfig?: FileUploadOptions;

Expand Down

0 comments on commit 88417b7

Please sign in to comment.