Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Server 2.0 #1125

Merged
merged 649 commits into from
Jul 14, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
649 commits
Select commit Hold shift + click to select a range
63b8b22
docs: correct headers on 2.0 migration guide
evans Jun 7, 2018
f9cd6ce
docs: fix comments about gql-tag
evans Jun 7, 2018
a04bea3
cloudflare: set as private while permissions are worked out
evans Jun 7, 2018
4c6352a
v2.0.0-beta.5
evans Jun 7, 2018
5f30792
Add BadUserInputError as extension of ApolloError (#1143)
clarencenpy Jun 8, 2018
32968bf
Update to apollo-tracing which works with new handler ordering
glasser Jun 8, 2018
b5eab35
Remove duplicate common dependencies to avoid Lerna warnings
martijnwalraven Jun 11, 2018
1e1b49e
Update devDependencies, including typescript
martijnwalraven Jun 11, 2018
5a1598c
Remove deprecated supertest-as-promised
martijnwalraven Jun 11, 2018
0aff6c8
Update compilation target to ES2017 and fix issus
martijnwalraven Jun 11, 2018
4a068cf
Add engines field with node >= 8 in package.json
martijnwalraven Jun 11, 2018
301e144
Test on Node 8 and 10 on Circle CI
martijnwalraven Jun 11, 2018
df30e42
Fix Circle CI config
martijnwalraven Jun 11, 2018
c5892f6
Disable failing file upload test
martijnwalraven Jun 11, 2018
2f44a42
Remove Object.setPrototypeOf workaround for error subclasses on ES5
martijnwalraven Jun 11, 2018
e4164c8
Enable esModuleInterop and fix imports
martijnwalraven Jun 11, 2018
1af0577
Install npm@6 in CI
martijnwalraven Jun 11, 2018
ff90e5c
upgrade apollo-engine-reporting (better error handling)
glasser Jun 11, 2018
a7cd3a4
Apollo Server 2:Automatic Persisted Queries (#1149)
evans Jun 11, 2018
3e93524
v2.0.0-beta.6
glasser Jun 11, 2018
dbfa57c
dep on express (there is an import), other tweaks
glasser Jun 12, 2018
df8e487
v2.0.0-beta.7
glasser Jun 12, 2018
ba31cf7
Integrations export their own ApolloServer (#1161)
evans Jun 13, 2018
db8eba8
v2.0.0-beta.8
evans Jun 13, 2018
afcd170
core, integrations: break apart coupling of introspection and gui enable
evans Jun 13, 2018
83c866e
core: add graphql-tag as export
evans Jun 13, 2018
0178840
express, hapi: export ApolloServer
evans Jun 13, 2018
519b6fd
v2.0.0-beta.9
glasser Jun 13, 2018
1fd3b21
Remove engineProxy support
glasser Jun 13, 2018
40f9a49
Remove packages for frameworks that don't yet support 2.0
glasser Jun 13, 2018
e4a6e87
Remove graphiql support
glasser Jun 13, 2018
5e59605
docs: remove GraphiQL and old migration guides
evans Jun 13, 2018
2ff159d
Don't export middleware from packages
glasser Jun 13, 2018
e66f6db
fix: support Node 6 (#1171)
evans Jun 13, 2018
e420094
docs: remove old hapi migration and move images into same folder
evans Jun 13, 2018
eb0ae81
Update integration test suite to test ApolloServer
glasser Jun 13, 2018
e32fad6
Allow configuration of graphql-playground
glasser Jun 13, 2018
ddc589d
v2.0.0-beta.10
glasser Jun 13, 2018
559b21d
Restore comment from Revert "Test on Node 8 and 10 on Circle CI"
abernix Jun 14, 2018
01c7c37
start to refactor subscriptions
glasser Jun 13, 2018
54ced71
initial implementation of createSubscriptionServer
evans Jun 14, 2018
304debf
errors insubscription server creation and non-async regsiterServer fo…
evans Jun 14, 2018
9d853f4
move ApolloServer tests into integration tests from core
evans Jun 14, 2018
3279991
move registerServer into class as applyMiddleware function
evans Jun 14, 2018
7ded129
docs: replace registerServer with applyMiddleware
evans Jun 14, 2018
95fe31d
docs: server.listen to app.listen for express examples
evans Jun 14, 2018
afda134
improve listen API with callbacks
glasser Jun 14, 2018
1707967
Specify full path in tsconfig imports
glasser Jun 14, 2018
3fccd43
simplify upload enhanceSchema, rename to installSubscriptionHandlers
glasser Jun 14, 2018
46bb367
cloudflare package does not need to be private
glasser Jun 14, 2018
d006d4d
v2.0.0-beta.11
glasser Jun 14, 2018
1f9f307
docs: initial engine migration guide
evans Jun 14, 2018
439ec44
core: add Scalar Upload with schema is made execuable
evans Jun 14, 2018
685d339
Apollo Server 2.0 - Caching + RESTDataSource (#1163)
martijnwalraven Jun 15, 2018
9588468
v2.0.0-rc.0
evans Jun 15, 2018
1592c54
docs: change beta to release candidate
evans Jun 15, 2018
d4a38b8
AS2: Docs for subscriptions (#1165)
daniele-zurico Jun 15, 2018
ff91ba9
docs: add subscriptions by @daniele-zurico into the index
evans Jun 15, 2018
fdfb532
docs: Correct typos in Features/Subscriptions. (#1178)
daniele-zurico Jun 15, 2018
d28982b
docs: Add version "2" back, which was lost in a merge.
abernix Jun 15, 2018
0eed623
docs: add install for rest data source
evans Jun 15, 2018
cba05d9
remove operation store module because of apq's
evans Jun 15, 2018
b6f88d5
express: remove console logs from data source test
evans Jun 15, 2018
f4d1ac5
docs: Change links away from contentless deployment index page.
abernix Jun 16, 2018
7c1f7a6
Change to in new pattern of using apollo server 2
unicodeveloper Jun 17, 2018
491997a
Merge pull request #1185 from apollographql/fix-errors
Jun 17, 2018
3cb2e41
remove extra '/' from docs
amitport Jun 18, 2018
f07afc1
added missing 'new' keyword
Jun 18, 2018
9070a96
Merge pull request #1186 from amitport/patch-1
Jun 18, 2018
2913465
Merge pull request #1187 from danferreira/fix-docs
Jun 18, 2018
da2c95c
Remove workaround for TS unused locals
martijnwalraven Jun 18, 2018
7496eb0
Run test in apollo-datasource-rest as part of monorepo tests
martijnwalraven Jun 18, 2018
43627ec
Add support for Redis and Memcached with ttls (#1191)
clarencenpy Jun 19, 2018
86fd88e
Add type parameter for responses and add PATCH method (#1190)
fabien0102 Jun 19, 2018
cde5434
Extract URLSearchParamsInit type and use it in RESTDataSource
martijnwalraven Jun 19, 2018
74d7f53
Add any as default type parameter for TResponse in RESTDataSource
martijnwalraven Jun 19, 2018
073655a
Remove willReceiveCache and willReceiveContext from RESTDataSource
martijnwalraven Jun 19, 2018
b76c100
Only attempt to parse responses with the right Content-Type as JSON
martijnwalraven Jun 19, 2018
7f7f70e
docs: Update middleware migration instructions in 2.0 migration guide.
abernix Jun 19, 2018
60c0f58
Update data sources docs
martijnwalraven Jun 19, 2018
387f250
rename BadUserInputError to UserInputError (#1197)
clarencenpy Jun 19, 2018
958fa65
Update data source docs and add instructions for Memcached and Redis …
clarencenpy Jun 19, 2018
3f3b0eb
Rename Memcached and Redis cache classes
martijnwalraven Jun 20, 2018
0928d79
Move in memory cache to apollo-server-caching
martijnwalraven Jun 20, 2018
d38e289
Log RESTDataSource requests in development
martijnwalraven Jun 20, 2018
655ead3
Move shared mocks to top-level and enforce noImplicitAny
martijnwalraven Jun 20, 2018
aa0650c
Remove unnecessary workaround for ES5
martijnwalraven Jun 20, 2018
17582a7
chore(deps): update dependency meteor-theme-hexo to v1.0.14
abernix Jun 20, 2018
f4bba1d
docs: Add `version` to _config.yml for "Edit on GitHub" on version br…
abernix Jun 20, 2018
406b4fd
update link to point to the package on npmjs
clarencenpy Jun 20, 2018
0d863f7
Add file uploads feature section to Apollo Server docs
unicodeveloper Jun 20, 2018
9af856c
Typescript Improvements and esModuleInterop fix (#1210)
evans Jun 20, 2018
70a0fad
export UserInputError from express and hapi integrations (#1206) (#1208)
clarencenpy Jun 20, 2018
7c622aa
hapi: tests, add types, and fix #1195 (#1211)
evans Jun 20, 2018
8914b13
Add error handling to RESTDataSource and extract apollo-server-errors
martijnwalraven Jun 20, 2018
22ee1d5
chore(deps): update dependency meteor-theme-hexo to v1.0.15
abernix Jun 20, 2018
1424727
Remove logFunction
martijnwalraven Jun 21, 2018
71a403d
Set cached response TTL based on max-age
martijnwalraven Jun 21, 2018
d187870
Move Uploads to constructor and remove enhanceSchema (#1204)
evans Jun 21, 2018
2d624c9
Remove direct dependency on node-fetch and add @types/ws
martijnwalraven Jun 21, 2018
35ac867
Avoid direct imports of node-fetch
martijnwalraven Jun 21, 2018
36c595b
Upgrade apollo-engine-reporting to beta.13
glasser Jun 21, 2018
65d7b10
CDN cache-control headers (#1138)
evans Jun 21, 2018
bb4f1c3
Apollo Server 2.0: AWS Lambda Integration (#1188)
alessiodionisi Jun 21, 2018
8bd5045
lambda: fix typings
evans Jun 21, 2018
3bc09de
v2.0.0-rc.1
evans Jun 21, 2018
742fb41
Amortize encoding over each trace
glasser Jun 21, 2018
944a641
Add missing apollo-upload-server dependency (#1221)
olistic Jun 22, 2018
4770f38
v2.0.0-rc.2
evans Jun 22, 2018
ebacd8f
Add type dependencies to apollo-server-express
martijnwalraven Jun 22, 2018
4b0a8f4
Add file upload page
unicodeveloper Jun 22, 2018
d25aa20
Add Lambda docs
unicodeveloper Jun 22, 2018
1bf2313
Initial documentation
unicodeveloper Jun 22, 2018
5a8043b
Add meat to the file upload page
unicodeveloper Jun 22, 2018
5dfe2b5
Add file upload section on sidebar
unicodeveloper Jun 22, 2018
ae14665
include test for tracing and add server creation helper method
evans Jun 22, 2018
98fd7ae
test cache-control set to false after bug from #1217
evans Jun 22, 2018
c8d747b
Document Reporting to Engine and Add to migration guide (#1223)
evans Jun 22, 2018
6918508
Export UserInputError from lambda integration (#1230)
olistic Jun 22, 2018
7dc280d
Fix Typo resovers -> resolvers (#1233)
Jun 22, 2018
76da232
Add graphql peer dependency to server integrations (#1232)
olistic Jun 22, 2018
e62dc4e
AS2: Support APQ for Batches (#1234)
evans Jun 22, 2018
049a61a
Send APQ info to traces
glasser Jun 23, 2018
846579d
update README's and remove docs for registerServer (fixes #1216)
evans Jun 23, 2018
acedc26
v2.0.0-rc.3
martijnwalraven Jun 24, 2018
73ec5e0
docs: fix typo in whats new documentation
briandennis Jun 24, 2018
96ff4b6
Merge pull request #1239 from briandennis/patch-1
Jun 24, 2018
85aefb7
Fix
unicodeveloper Jun 25, 2018
7f1b59d
Add feedback
unicodeveloper Jun 25, 2018
daaa522
Merge pull request #1228 from apollographql/add-lambda-docs
Jun 25, 2018
ef5e1e1
Resolve comflicts
unicodeveloper Jun 25, 2018
4d7a34f
Add trailing slash to baseURL of data source if needed
martijnwalraven Jun 25, 2018
f3fd52d
Add lambda to sidebar (#1240)
Jun 25, 2018
b6e2096
Allow passing a body to POST, PATCH and PUT in data source
martijnwalraven Jun 25, 2018
325f114
apollo-engine-reporting: more aggressive signataure
glasser Jun 25, 2018
2ca26ab
v2.0.0-rc.4
glasser Jun 25, 2018
c58665a
Add feedbacl
unicodeveloper Jun 25, 2018
2097643
Merge pull request #1207 from apollographql/add-file-uploadspage
Jun 25, 2018
c886303
Hapi: reenable cors test
evans Jun 25, 2018
d85ef48
Ensures formatError receives a value that passes instanceof Error (#1…
evans Jun 25, 2018
2b925c4
add graphql dependency to docs (#1244)
alessiodionisi Jun 25, 2018
3ad0519
v2.0.0-rc.5
evans Jun 25, 2018
84f13ba
docs: add graphql install next to integrations npm install's
evans Jun 26, 2018
7e35305
Always clone the context if it's not a function
martijnwalraven Jun 26, 2018
6bf286d
Fix async context test and add test for cloning
martijnwalraven Jun 26, 2018
4a05521
Add performance monitoring to what's new
unicodeveloper Jun 26, 2018
caee155
Fix the path
unicodeveloper Jun 26, 2018
61af12d
Merge pull request #1249 from apollographql/add-metrics-to-whatsnew
Jun 26, 2018
b54402f
Update unions-interfaces.md (#1196)
benwaffle Jun 26, 2018
6ccb790
added constructors
JakeDawkins Jun 25, 2018
6f99c45
added slash to end of example base urls
JakeDawkins Jun 25, 2018
a4f0336
Fix Circle CI badge in README
martijnwalraven Jun 26, 2018
e0c169d
Update GraphQL Playground to fix tracing
martijnwalraven Jun 27, 2018
8c9eaf0
Added other HTTP methods to DataSource Docs (#1254)
JakeDawkins Jun 27, 2018
62ff5c6
Improve Subscriptions Dev/Docs Experience (#1255)
evans Jun 27, 2018
28cec7e
docs: Engine Reporting API and pass Engine API key in constructor (#1…
evans Jun 27, 2018
ea25edc
docs: Use sentence case for title names. (#1258)
abernix Jun 27, 2018
8ef1818
Fix graphql-tools/subscriptions dependencies and exports (#1257)
olistic Jun 27, 2018
c2e4dfb
Import graphql-extensions+apollo-engine-reporting/no global apollo-se…
martijnwalraven Jun 27, 2018
beb1c23
Add Zeit deployment guide
unicodeveloper Jun 28, 2018
01efbf0
link to now in the sidebar
unicodeveloper Jun 28, 2018
a823bd8
Fix grammar
unicodeveloper Jun 28, 2018
290b9f0
Remove apollo-engine. Apollo Server's got it covered :fire:
unicodeveloper Jun 28, 2018
06db214
Add feedback
unicodeveloper Jun 28, 2018
7718cd2
Remove unecessary code highlighting
unicodeveloper Jun 28, 2018
a796420
Last unecessary code highlighting removed.
unicodeveloper Jun 28, 2018
49015f9
Merge pull request #1269 from apollographql/add-zeit-deploy
Jun 28, 2018
43c36c4
Don't expect request.url to be a well-formed URL
martijnwalraven Jun 28, 2018
49a802d
Don't attempt to parse request.url at all
martijnwalraven Jun 28, 2018
53d7a75
Re-export Request from apollo-datasource-rest
martijnwalraven Jun 28, 2018
c525818
export Request from graphql-extensions
evans Jun 28, 2018
738a933
docs: add persited query cache configuration
evans Jun 28, 2018
9b67773
docs: add callout to install apollo-server-express
evans Jun 28, 2018
67c4812
docs: update engine option to ApolloServer constructor
evans Jun 28, 2018
84233d2
Centralize playgroundVersion in ApolloServerBase and remove pass-thro…
martijnwalraven Jun 29, 2018
8ea36d8
Use scoped graphql-playground-html
martijnwalraven Jun 29, 2018
e0f7052
Errors Lifecycle: user extensions > engine reporting > formatError (#…
evans Jun 29, 2018
80174d2
Further improves subscriptions docs (#1263)
evans Jun 29, 2018
59ca96c
docs(migration-engine): fix typo in code example (#1273)
emmenko Jun 29, 2018
cbb5bf3
[2.0] Switch apollo-engine-reporting to use fetch instead of the Node…
martijnwalraven Jun 29, 2018
63f6b47
Publish
evans Jun 29, 2018
3ad0c43
Fix test typings
martijnwalraven Jun 30, 2018
660c034
Remove APQ, CDN integration and file uplaods from side bar
unicodeveloper Jul 2, 2018
9d326ff
Delete the files
unicodeveloper Jul 2, 2018
6c583d6
Set up redirects
unicodeveloper Jul 2, 2018
d75a4d8
Merge pull request #1283 from apollographql/remove-uploads
Jul 2, 2018
35776c9
remove .DS_Store (#1280)
chentsulin Jul 2, 2018
b812eec
added related guides (#1286)
JakeDawkins Jul 2, 2018
11f0383
Add npm start script to now setup (#1276)
vpicone Jul 2, 2018
dae5349
Clarify docs for hybrid connections with middleware (#1285)
M-Zuber Jul 2, 2018
1947892
Removes flattening of Errors inside of formatApolloErrors (#1288)
evans Jul 2, 2018
0351751
lambda: add existance check for result
evans Jul 3, 2018
16a336d
Remove unused core-js and source-map-support dependencies from graphq…
martijnwalraven Jul 3, 2018
928ef7d
Allow dynamic configuration of data sources (#1277)
martijnwalraven Jul 3, 2018
23965de
Add example of intercepting fetches and resolving URLs to data source…
martijnwalraven Jul 3, 2018
0b5c7f3
Export RequestOptions from apollo-datasource-rest
martijnwalraven Jul 3, 2018
8c8729f
fix README badge links and test imports (#1281)
chentsulin Jul 3, 2018
8496387
Import apollo-tracing-js (#1292)
evans Jul 3, 2018
19c8adf
Import apollo-cache-control-js (#1294)
evans Jul 3, 2018
73a5da1
Replaced RESTDataSource with generic DataSource typing (#1293)
danilobuerger Jul 4, 2018
4114bc5
Enable strict typing for apollo-server-core and fix issues
martijnwalraven Jul 4, 2018
4793c5a
Rename apollo-cache-control-js and apollo-tracing-js and unify configs
martijnwalraven Jul 4, 2018
94d4d49
Use for-of loops instead of standard for loops
martijnwalraven Jul 4, 2018
c356bcf
Apollo Server 2 Micro integration (#1279)
hwillson Jul 5, 2018
02d3155
Add GraphQL Playground Documentation (#1270)
evans Jul 5, 2018
dbaa465
Apollo Server 2 Koa integration (#1282)
chentsulin Jul 6, 2018
8ad3137
Follow-up editorial for GraphQL Playground doc. (#1270).
abernix Jul 9, 2018
075c052
Also rename playground to graphql-playground in _config.yml.
abernix Jul 9, 2018
314f0ec
Hint about Upload scalar when setting schema manually (#1318)
danilobuerger Jul 9, 2018
d01b18a
Update GraphQL Playground version
martijnwalraven Jul 9, 2018
f8feca8
Move lru-cache dependency to apollo-server-caching
martijnwalraven Jul 9, 2018
9e60f42
Use main cache for persisted queries by default
martijnwalraven Jul 10, 2018
f551e2b
Use apq prefix for persisted query caching
martijnwalraven Jul 10, 2018
e29f804
Enable engine reporting in Lambda (#1313)
evans Jul 10, 2018
13b796f
Publish
evans Jul 10, 2018
61b4939
Enable GraphQLUpload for Apollo Server 2.0 (#1322)
Jul 10, 2018
e83dcbc
Round the ttl to an integer so that redis doesn't b0rk (#1323)
raduachim Jul 10, 2018
2d7af8b
Add CDN and APQ to What's new (#1320)
evans Jul 10, 2018
f9373bf
add graphql types referenced in creating-directives
evans Jul 10, 2018
9034ac9
Add redirect for file-uploads (#1328)
Jul 10, 2018
890e10b
chore(deps): update dependency apollo-hexo-config to v1.0.8 (#1329)
renovate[bot] Jul 10, 2018
ecc5669
RESTDataSource: add didReceiveResponse method (#1325)
Jul 11, 2018
de4760b
Expose Cors option from vanilla ApolloServer constructor (#1335)
evans Jul 11, 2018
c200df0
RESTDataSource: Add data to errors thrown for error responses
martijnwalraven Jul 11, 2018
1022ae1
RESTDataSource: Do not serialize body values that aren't objects (#1316)
heralden Jul 11, 2018
54a8fac
RESTDataSource: Serialize request bodies that have a toJSON method as…
martijnwalraven Jul 11, 2018
299018f
[apollo-server-koa] use exported bodyParser.Options type instead of i…
chentsulin Jul 11, 2018
f055d28
Extract abstract DataSource superclass into apollo-datasource package
martijnwalraven Jul 11, 2018
11b8671
Move `gui` option into constructor and use `playground` (#1297)
zionts Jul 11, 2018
7f157da
Fixed a couple typos (#1309)
sasadjolic Jul 11, 2018
78dcf4f
remove calculate headers as a function (#1337)
evans Jul 13, 2018
990d915
Apollo Server 2: Remove formatParams (#1331)
evans Jul 13, 2018
a31501f
DeleteD
unicodeveloper Jul 13, 2018
2775eeb
Merge branch 'abernix/follow-up-1270' into version-2
unicodeveloper Jul 13, 2018
fbf6c6b
update playground to include #1319
evans Jul 13, 2018
d4a8e1a
Throw error in applyMiddleware for vanilla apollo-server (#1345)
evans Jul 13, 2018
7f11c60
Fix broken link to CDN guide, which is now on /docs/.
abernix Jul 13, 2018
170f072
bring version-2 up to date
evans Jul 13, 2018
c3cee59
Merge branch 'master' into version-2
evans Jul 13, 2018
c00918b
remove apollo-server-fastify
evans Jul 13, 2018
b7c5cea
fix export of hapi middleware
evans Jul 13, 2018
31e93d0
remove setup
evans Jul 13, 2018
467b224
fix hapi readme
evans Jul 13, 2018
c18c7a3
remove unused tests
evans Jul 13, 2018
17ed370
Update meteor-theme-hexo to the latest version.
abernix Jul 13, 2018
7d7fef6
Merge pull request #1348 from apollographql/merge-master
evans Jul 13, 2018
9862b5c
Merge branch 'master' into version-2
evans Jul 13, 2018
281760b
docs: Update blog URLs to reference blog.apollographql.com.
abernix Jul 13, 2018
2c23600
Merge branch 'master' into version-2
evans Jul 14, 2018
c800071
update changelog for RC's and betas
evans Jul 14, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/apollo-server-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
},
"dependencies": {
"apollo-cache-control": "^0.1.1",
"apollo-engine-reporting": "0.0.0-beta.11",
"apollo-engine-reporting": "0.0.0-beta.12",
"apollo-tracing": "^0.2.0-beta.1",
"graphql-extensions": "0.1.0-beta.13",
"graphql-subscriptions": "^0.5.8",
Expand Down
4 changes: 4 additions & 0 deletions packages/apollo-server-core/src/ApolloServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,10 @@ const typeDefs = gql\`${startSchema}\`
if (this.engineProxy) await this.engineProxy.stop();
if (this.subscriptionServer) await this.subscriptionServer.close();
if (this.http) await new Promise(s => this.http.close(s));
if (this.engineReportingAgent) {
this.engineReportingAgent.stop();
await this.engineReportingAgent.sendReport();
}
}

private createSubscriptionServer(
Expand Down
1 change: 1 addition & 0 deletions packages/apollo-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"dependencies": {
"apollo-server-core": "^2.0.0-beta.6",
"apollo-server-express": "^2.0.0-beta.6",
"express": "^4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really an issue and probably not worth fixing now, but unless we keep the versions between apollo-server and apollo-server-express in sync this does lead to a Lerna warning:

lerna WARN EHOIST_PKG_VERSION "apollo-server-express" package depends on express@4.16.3, which differs from the hoisted express@^4.0.0.

"graphql-subscriptions": "^0.5.8"
}
}
4 changes: 4 additions & 0 deletions packages/apollo-server/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Note: express is only used if you use the ApolloServer.listen API to create
// an express app for you instead of registerServer (which you might not even
// use with express). The dependency is unused otherwise, so don't worry if
// you're not using express or your version doesn't quite match up.
import express from 'express';
import { Request } from 'express';
import { registerServer } from 'apollo-server-express';
Expand Down