Add support for Redis and Memcached #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- apollo-server-caching (exports interface for KeyValueCache) - apollo-server-caching-memcached - apollo-server-caching-redis One issue now is that there is duplication of mocks and test code in each of the packages. It would be better if we had centralized integration tests for all cache connectors, community contributed or otherwise.
|
I think we can shorten the names down to |
evans
reviewed
Jun 18, 2018
| "dependencies": { | ||
| "apollo-server-env": "^2.0.0-rc.0", | ||
| "apollo-server-caching": "^2.0.0-rc.0", | ||
| "memcached": "^2.2.2" |
There was a problem hiding this comment.
Installing the types for these packages will provide a lot more confidence that we are doing the right thing.
npm install -D @types/memcached
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/redis/index.d.ts
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/memcached/index.d.ts
clarencenpy
force-pushed
the
server-2.0/caching-basic
branch
from
a4dadf3 to
7e6d282
Compare
evans
approved these changes
Jun 18, 2018
There was a problem hiding this comment.
Looks good! Let's squash it and include it in the next release 🎉
Great work @clarencenpy
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored caching connectors for Redis/Memcached into their own packages.
One issue now is that there is duplication of mocks and test code in each of the packages. It would be better if we had centralized integration tests for all cache connectors, community contributed or otherwise.