Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes applyMiddleware from apollo-server #1314

Closed
wants to merge 3 commits into from

Conversation

evans
Copy link
Contributor

@evans evans commented Jul 9, 2018

To make the transition from no middleware to using an express server, we're exposing applyMiddleware in apollo-server's ApolloServer. This enables users to configure the gui and other options for the vanilla version of apollo-server.

The argument in the past against this was the possibility of moving to a different underlying framework. We're still able to do so, since in the cases that a user does not specify an app in applyMiddleware, so we are not locked into a framework unless the user requires it.

@evans evans requested review from abernix and unicodeveloper July 9, 2018 07:15
@evans evans closed this Jul 11, 2018
@evans evans deleted the server-2.0/a-s-applyMiddleware branch July 11, 2018 07:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant