Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Cors option from vanilla ApolloServer constructor #1335

Merged
merged 4 commits into from
Jul 11, 2018

Conversation

evans
Copy link
Contributor

@evans evans commented Jul 11, 2018

This places a cors option inside of apollo-server's constructor. In order to get to create a production server, cors must be configurable. To get to production, we should not have to use an alternative integration, so while this removes the universal constructor, it's a necessary change.

Fixes #1326

@evans evans requested a review from martijnwalraven July 11, 2018 16:52
@martijnwalraven
Copy link
Contributor

I made some small capitalization changes to the docs, but looks good to me!

@evans evans merged commit de4760b into version-2 Jul 11, 2018
@evans evans deleted the server-2.0/a-s-cors branch July 11, 2018 20:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants