-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed GraphQL Playground with custom configuration in production. #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
🪲 bug
label
Aug 6, 2018
@nderscore: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
ghost
added
the
🪲 bug
label
Aug 6, 2018
nderscore
added a commit
to nderscore/apollo-server
that referenced
this pull request
Aug 6, 2018
ghost
added
the
🪲 bug
label
Aug 6, 2018
Edit: Tests seem to be passing now. |
…duction environments. * Updated logic in `createPlaygroundOptions` to cast the `playground` option to a boolean if it is defined. Fall back to `isDev` logic only if undefined. * Updated unit test for partial graphql playground options to emulate a 'production' environment, mimicking the scenario that was broken before.
nderscore
force-pushed
the
production-playground
branch
from
August 10, 2018 14:10
8764fef
to
ab18feb
Compare
abernix
approved these changes
Aug 14, 2018
hwillson
approved these changes
Aug 14, 2018
@nderscore Thank you so much! We'll get this out asap |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1386. Many thanks to @thinkjson for investigating and raising this issue, as well as the proposed solution.
This is an alternative to PR #1417. While that PR seeked to solve the issue by altering the playground configuration object to add a new option for enabling/disabling playground, this solution is more aligned with the existing configuration and (my) expectations about how it should behave.
Fixed support for GraphQL Playground with custom configuration in production environments.
createPlaygroundOptions
to cast theplayground
option to a booleanif it is defined. Fall back to
isDev
logic only if undefined.environment, mimicking the scenario that was broken before.
TODO: