Updated Google Cloud Function request handler to handle null or undefined req.path #1674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
apollo-server-cloud-functions
exported handler doesn't handle bare endpoints, that means for example, requestinghttps://us-central1-apollo-gcf-test.cloudfunctions.net/handler
will return a 404, but accessinghttps://us-central1-apollo-gcf-test.cloudfunctions.net/handler/
(notice the added slash) will.This is due to the way GCF sets request params, in which the in the first case
req.path
will be set tonull
, and in the second it will be set to"/"
TODO: