-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract TypeScript utility types to apollo-server-env
#2415
Conversation
We do the same in `apollo-env`, which this package will likely be merged with when we drop Node 6 support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks! I'll follow this up with a couple changes that take more complete advantage of it.
…rver-env`. Now that the `ValueOrPromise` and `WithRequired` types are more ubiquitously available after @martijnwalraven's #2415 which brought them to `apollo-server-env`, we can change the existing cases where we've used these patterns or depended on them from less-than-ideal modules (like `apollo-server-plugin-base`).
…er-env`. Now that the `ValueOrPromise` and `WithRequired` types are more ubiquitously available after @martijnwalraven's #2415 which brought them to `apollo-server-env`, we can change the existing cases where we've used these patterns or depended on them from less-than-ideal modules (like `apollo-server-plugin-base`).
…er-env`. Now that the `ValueOrPromise` and `WithRequired` types are more ubiquitously available after @martijnwalraven's #2415 which brought them to `apollo-server-env`, we can change the existing cases where we've used these patterns or depended on them from less-than-ideal modules (like `apollo-server-plugin-base`).
…l#2415) We do the same in `apollo-env`, which this package will likely be merged with when we drop Node 6 support.
…er-env`. (#2417) * Propagate new `ValueOrPromise`/`WithRequired` types from `apollo-server-env`. Now that the `ValueOrPromise` and `WithRequired` types are more ubiquitously available after @martijnwalraven's #2415 which brought them to `apollo-server-env`, we can change the existing cases where we've used these patterns or depended on them from less-than-ideal modules (like `apollo-server-plugin-base`). * fixup! Propagate new `ValueOrPromise`/`WithRequired` types from `apollo-server-env`.
On release-2.5.0, I undid the part of this PR that added an implicit dependency (for TypeScript users) from apollo-server-plugin-base onto apollo-server-env with only a declared I'm not sure if this reversion is the right long term answer vs making the |
…llo-server-env`. (#2417)" This reverts commit ceee5db. Revert this and #2415 on release-2.5.0 because having apollo-server-plugin-base use newly added types from apollo-server-env yet only declare it as a devDependency meant that TypeScript consumers of the published alpha packages could end up breaking because the import of apollo-server-env could be resolved to an older version of the package without the newly added types. I'm not sure if this reversion is the right long term answer vs making the apollo-server-env dependency non-dev, but this will let the alpha process for 2.5.0 move forward for now.
This reverts commit 3a3c67d. Revert this and #2417 on release-2.5.0 because having apollo-server-plugin-base use newly added types from apollo-server-env yet only declare it as a devDependency meant that TypeScript consumers of the published alpha packages could end up breaking because the import of apollo-server-env could be resolved to an older version of the package without the newly added types. I'm not sure if this reversion is the right long term answer vs making the apollo-server-env dependency non-dev, but this will let the alpha process for 2.5.0 move forward for now.
…llo-server-env`. (#2417)" This reverts commit ceee5db. Revert this and #2415 on release-2.5.0 because having apollo-server-plugin-base use newly added types from apollo-server-env yet only declare it as a devDependency meant that TypeScript consumers of the published alpha packages could end up breaking because the import of apollo-server-env could be resolved to an older version of the package without the newly added types. I'm not sure if this reversion is the right long term answer vs making the apollo-server-env dependency non-dev, but this will let the alpha process for 2.5.0 move forward for now.
This reverts commit 3a3c67d. Revert this and #2417 on release-2.5.0 because having apollo-server-plugin-base use newly added types from apollo-server-env yet only declare it as a devDependency meant that TypeScript consumers of the published alpha packages could end up breaking because the import of apollo-server-env could be resolved to an older version of the package without the newly added types. I'm not sure if this reversion is the right long term answer vs making the apollo-server-env dependency non-dev, but this will let the alpha process for 2.5.0 move forward for now.
We do the same in
apollo-env
, which this package will likely be merged with when we drop Node 6 support.