-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix fastify startup deprecation warning #3561
Conversation
@randomnerd: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Could someone please do a review? Thanks! |
updated to master, approval still required |
any update? |
@martijnwalraven @abernix please review this, need update with fastify |
This change had already been made previously on #3527 |
Duplicate of #2391 |
Closing as duplicate of #3527 and #2391. It is absolutely on my mind to get the major version bumped in the next major version of Apollo Server. I understand the disappointing delay, in particular on the Fastify updates, but opening more of these same/similar PRs won't get the blockers unblocked for that work. We are trying to get to a stage where this is less problematic both now, and in the future. (See also, #3184 and #3576) |
Update the
fastify
packageUse the preHandler instead beforeHandlers - Fix Issue #3477