Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix fastify startup deprecation warning #3561

Closed
wants to merge 10 commits into from

Conversation

randomnerd
Copy link

Update the fastify package
Use the preHandler instead beforeHandlers - Fix Issue #3477

@apollo-cla
Copy link

@randomnerd: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@randomnerd
Copy link
Author

Could someone please do a review? Thanks!

@randomnerd
Copy link
Author

updated to master, approval still required

@zieglar
Copy link

zieglar commented Dec 10, 2019

any update?

@zieglar
Copy link

zieglar commented Dec 15, 2019

@martijnwalraven @abernix please review this, need update with fastify

@pauloedurezende
Copy link
Contributor

This change had already been made previously on #3527

@markrzen
Copy link

Duplicate of #2391

@abernix
Copy link
Member

abernix commented Apr 22, 2020

Closing as duplicate of #3527 and #2391. It is absolutely on my mind to get the major version bumped in the next major version of Apollo Server. I understand the disappointing delay, in particular on the Fastify updates, but opening more of these same/similar PRs won't get the blockers unblocked for that work. We are trying to get to a stage where this is less problematic both now, and in the future. (See also, #3184 and #3576)

@abernix abernix closed this Apr 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants