Preparations for graphql@15.x. #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, use `getIntrospectionQuery` instead, which has been around since before graphql@0.13.x, thus within our supported version ranges.
This file now lives at `getIntrospectionQuery`.
I'm assuming we'll want to keep this change which was also applied upstream, though I'm not sure what our longer term plans are for keeping up with these changes. Ref: https://github.com/graphql/graphql-js/pull/2177/files#diff-71ba52e9c625f826d2b0df2963c8633aR320
In `graphql@15`, empty descriptions are intentionally included in the SDL output. In order to be excluded entirely, they must be absent (or `null`). Ref: graphql/graphql-js#2177
trevor-scheer
approved these changes
Jan 27, 2020
abernix
added a commit
that referenced
this pull request
Jun 8, 2020
In a general sense this just updates tests to accommodate the new error conditions and schema hashes since a lot of the work has already been done in #3712 / 131c9b8. A larger note is due to explain the updating the snapshots. Those changes are due the fact that types returned by, e.g. `getImplementation`, will now be dependent on the order that those types first appear in the schema. See the referenced issues, the first of which implemented the change and the second which indicates the motivation. Ref: graphql/graphql-js#2410 Ref: graphql/graphql-js#2362 Ref: #3712 (131c9b8)
abernix
added a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
* Adjust test to not use deprecated `introspectionQuery` constant. Instead, use `getIntrospectionQuery` instead, which has been around since before graphql@0.13.x, thus within our supported version ranges. * Adjust documentation links for moved `introspectionQuery` page. This file now lives at `getIntrospectionQuery`. * Applying upstream modification to `printDescription`. I'm assuming we'll want to keep this change which was also applied upstream, though I'm not sure what our longer term plans are for keeping up with these changes. Ref: https://github.com/graphql/graphql-js/pull/2177/files#diff-71ba52e9c625f826d2b0df2963c8633aR320 * Remove empty descriptions which will be included in SDL w/graphql@15. In `graphql@15`, empty descriptions are intentionally included in the SDL output. In order to be excluded entirely, they must be absent (or `null`). Ref: graphql/graphql-js#2177 Apollo-Orig-Commit-AS: apollographql/apollo-server@131c9b8
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the changes necessary to accommodate deprecations in graphql@15.x, but does not go so far as to update this repository's
devDependenciesto use the15.xversion. (This will occur in a follow-up PR and will include the commits seen in abernix/graphql-js-v15...abernix/graphql-js-v15-after-devDependency-gets-updated).To reiterate, all of the changes included in this change-set are to address deprecations in
graphql@15. Despite their deprecations in versions pre-graphql@0.13(the earliest peer dependency range that Apollo Server 2.x technically supports), we have continued to rely on these methods despite them having newer APIs available. That's just an artifact of us having leveragedgraphql-jsfor so many years.In another follow-up PR, I intend to expand the
peerDependenciesrange of Apollo Server to includegraphql-js@15.xpre-release versions, in order to allow the community to try it out in their own projects without peer dependency warnings. (Though it's worth noting that after this PR lands and is released, there's nothing stopping anyone from trying that on their own since peer dependency warnings are simply warnings.)