Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Introduce "tracing" plugin and switch request pipeline to use it. #3991

Merged
merged 15 commits into from
May 12, 2020

Commits on Apr 15, 2020

  1. refactor: Introduce "tracing" plugin and switch request pipeline to u…

    …se it.
    
    This commit introduces a `plugin` (named) export from the `apollo-tracing`
    package, which uses the new "plugin" hooks rather than the previous
    implementation (exported as `TracingExtension`) which uses the
    soon-to-be-deprecated "extensions" hooks.  The functionality is intended to
    be identical, in spirit.
    
    Since the delta of the commits was otherwise confusing, I've left the
    `TracingExtension` present and exported and will remove it in a subsequent
    commit.
    
    Briefly summarizing what the necessary changes were:
    
    1. We no longer use a class instance to house the extension, which was
       necessitated by the `graphql-extensions` API.  This means that uses of
       `this` have been replaced with function scoped variables by the same name.
    2. The logic which actually does the formatting (previously handled by the
       `format` method in `graphql-extension`, now takes place within the plugin
       API's `willSendResponse` method.
    abernix committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    6009d8a View commit details
    Browse the repository at this point in the history
  2. eliminate!: Remove deprecated TracingExtension.

    This follows-up 672fa09 and removes the no-longer used/necessary
    `TracingExtension` extension which uses the soon-to-be-deprecated
    `graphql-extensions` API, now that it has been replaced with an
    implementation that uses the plugin API.
    abernix committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    8ec39c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Clear up error message in defense mechanism against existing tracing.

    This package should never have already set it itself prior to this point,
    but the circumstance exists that something (anything) else could have
    already used the `extensions` sink to attach a value.
    
    This guards against that.
    abernix committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    7e4cc4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fecea35 View commit details
    Browse the repository at this point in the history
  3. Add CHANGELOG.md for #3991.

    abernix committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    3e9188f View commit details
    Browse the repository at this point in the history
  4. Merge branch abernix/add-willResolveField-and-didResolveField into ab…

    …ernix/migrate-tracing-to-extension-api
    abernix committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    ff15d2a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Merge branch 'abernix/add-willResolveField-and-didResolveField' into …

    …abernix/migrate-tracing-to-extension-api
    abernix authored Apr 21, 2020
    Configuration menu
    Copy the full SHA
    267b2a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Update CHANGELOG.md

    abernix authored Apr 28, 2020
    Configuration menu
    Copy the full SHA
    98bae44 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'abernix/add-willResolveField-and-didResolveField' into …

    …abernix/migrate-tracing-to-extension-api
    abernix authored Apr 28, 2020
    Configuration menu
    Copy the full SHA
    0508cc4 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Revert "Update CHANGELOG.md"

    This reverts the public messaging about `tracing` deprecation in commit
    98bae44, for now, until we can discuss its
    fate a bit more, and how we intend on making up for that.
    abernix committed May 7, 2020
    Configuration menu
    Copy the full SHA
    ef4ed58 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'abernix/add-willResolveField-and-didResolveField' into …

    …abernix/migrate-tracing-to-extension-api
    abernix committed May 7, 2020
    Configuration menu
    Copy the full SHA
    4fbf8a7 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Merge branch 'abernix/add-willResolveField-and-didResolveField' into …

    …abernix/migrate-tracing-to-extension-api
    abernix committed May 8, 2020
    Configuration menu
    Copy the full SHA
    b789852 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'abernix/add-willResolveField-and-didResolveField' into …

    …abernix/migrate-tracing-to-extension-api
    abernix committed May 8, 2020
    Configuration menu
    Copy the full SHA
    7cea00f View commit details
    Browse the repository at this point in the history
  3. Switch to new willResolveField object parameter, rather position.

    Implements pattern gained by a926b7e in #3988.
    
    Ref: #3998
    abernix committed May 8, 2020
    Configuration menu
    Copy the full SHA
    d85276f View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Merge remote-tracking branch 'origin/release-2.14.0' into abernix/mig…

    …rate-tracing-to-extension-api
    abernix committed May 12, 2020
    Configuration menu
    Copy the full SHA
    a4d1380 View commit details
    Browse the repository at this point in the history