Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema-reporting: Update URL for schema reporting #4232

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

sachindshinde
Copy link
Contributor

We've set up a new sub-domain specifically for schema reporting at edge-server-reporting.api.apollographql.com. This PR accordingly updates the schema reporting URL in schemaReporter.ts.

@sachindshinde sachindshinde requested a review from jsegaran June 10, 2020 22:06
Copy link
Contributor

@jsegaran jsegaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think you just need to add this to the CHANGELOG.md

@sachindshinde sachindshinde force-pushed the sachin/change-schema-reporting-url branch from 75242ec to c31c545 Compare June 10, 2020 22:49
@sachindshinde sachindshinde requested a review from jsegaran June 10, 2020 22:56
@sachindshinde sachindshinde force-pushed the sachin/change-schema-reporting-url branch from c31c545 to 0b39cf2 Compare June 10, 2020 23:32
@sachindshinde sachindshinde merged commit b5936f5 into master Jun 10, 2020
@abernix abernix deleted the sachin/change-schema-reporting-url branch June 11, 2020 13:04
@abernix abernix added this to the Release 2.14.4 milestone Jun 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants