apollo-server-core: Improve SIGINT/SIGTERM handling #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
force-pushed
the
glasser/improve-signal-handling
branch
from
3046b8a to
de19e31
Compare
abernix
approved these changes
Mar 8, 2021
Two improvements to the SIGINT and SIGTERM signal handlers that are installed by default in non-test mode if you don't pass `stopOnTerminationSignals: false`. - If another SIGINT or SIGTERM is recieved while awaiting `stop()`, ignore it (ie, prevent the process from exiting if this was the only handler for that signal). This is implemented by switching the `process.once` to `process.on` and explicitly tracking if a signal has been received. Fixes #4931. - If `await this.stop()` throws, make sure to shut down the process anyway after logging. This does `process.exit(1)` instead of re-signaling because it can't be sure that the signal handler has been removed.
glasser
force-pushed
the
glasser/improve-signal-handling
branch
from
de19e31 to
eb9b5f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two improvements to the SIGINT and SIGTERM signal handlers that are installed by
default in non-test mode if you don't pass
stopOnTerminationSignals: false.If another SIGINT or SIGTERM is received while awaiting
stop(), ignoreit (ie, prevent the process from exiting if this was the only handler for that
signal). This is implemented by switching the
process.oncetoprocess.onand explicitly tracking if a signal has been received. Fixes SIGINT/SIGTERM handling doesn't wait for promises #4931.
If
await this.stop()throws, make sure to shut down the process anyway afterlogging. This does
process.exit(1)instead of re-signaling because it can'tbe sure that the signal handler has been removed.