apollo-server-types: move info.cacheControl 'declare module' here #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `info.cacheControl` available to TypeScript packages that depend on `apollo-server-types` rather than only being declared deep inside `apollo-server-core`. Additionally, it gives a name to type used for `info.cacheControl`. Intended for use cases like apollographql/federation#870 We've run into tricky issues with `declare module` before so if this ends up causing more problems than it's worth, we may revert it.
glasser
force-pushed
the
glasser/resolve-info-cache-control
branch
from
1d04bf5 to
539005d
Compare
trevor-scheer
approved these changes
Jul 19, 2021
glasser
added
size/small
This was referenced Jul 20, 2021
|
I tried updating from v2 to v3 and keep running into the following error: It seems to be related to this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
info.cacheControlavailable to TypeScript packages thatdepend on
apollo-server-typesrather than only being declared deepinside
apollo-server-core. Additionally, it gives a name to type usedfor
info.cacheControl.Intended for use cases like
apollographql/federation#870
We've run into tricky issues with
declare modulebefore so if thisends up causing more problems than it's worth, we may revert it.
Also change some more imports to
import type.