Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for swift 5.1 compiler warning when type is an enum with a none case #1482

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Fix for swift 5.1 compiler warning when type is an enum with a none case #1482

merged 2 commits into from
Sep 12, 2019

Conversation

cltnschlosser
Copy link
Contributor

@designatednerd
Copy link
Contributor

This looks good in theory but I want to test this against our existing codebase before I merge. I'm out moving until 3 September so it'll probably be around then, just FYI

@designatednerd designatednerd added 🐦 component - swift 🤖 component - codegen related to the codegen core packages labels Aug 23, 2019
@cltnschlosser
Copy link
Contributor Author

Yep, no problem. I saw that you were out, just thought I’d throw up the pull request anyway :)

@cltnschlosser
Copy link
Contributor Author

@designatednerd Have you had a chance to look at this?

@designatednerd
Copy link
Contributor

This will need some slight tweaks in light of #1515, which was just merged. Could you also add a line to the CHANGELOG for this as well?

@cltnschlosser
Copy link
Contributor Author

@designatednerd Updated it, but any advice on those CI failures. Seem to be completely unrelated.

@designatednerd
Copy link
Contributor

Those tests are super tempermental, I kicked both builds

@designatednerd
Copy link
Contributor

@cltnschlosser Mind pushing a dummy commit? Looks like our CI may have temporarily lost its mind and needs a kick at the push level.

@cltnschlosser
Copy link
Contributor Author

I pushed an empty file and that build passed, then I dropped that commit and the build failed :(

@designatednerd
Copy link
Contributor

:lolsob:

Kicking the builds again to see if it's a transient failure - it's possible dropping the commit might have kicked things back to an old build where things got screwed up though.

CHANGELOG.md Outdated Show resolved Hide resolved
@designatednerd
Copy link
Contributor

Yyyyyup. Looks like it needs another commit. I found a dumb thing it'd be nice to actually include so it doesn't have to be a total-dummy commit.

@designatednerd
Copy link
Contributor

🎉it worked! 🎉Now lemme test the branch against the SDK to figure out whether this needs to go as a patch or a minor - I suspect a patch but worth double checking...

@designatednerd
Copy link
Contributor

Patch it is! Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐦 component - swift 🤖 component - codegen related to the codegen core packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 11 warning for Optional.none in generated code
2 participants