Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling #302

Merged

Conversation

jerelmiller
Copy link
Member

Rather than erroring on the first encountered error, this PR will collect all errors up-front then report them at the same time. This also changes the format of the error to make it super clear which file the error was from.

Before
Screenshot 2023-06-09 at 6 05 38 PM

After
Screenshot 2023-06-09 at 6 05 24 PM

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2023

🦋 Changeset detected

Latest commit: 2efbe2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/generate-persisted-query-manifest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@jerelmiller jerelmiller force-pushed the file-name-anonymous-operation branch 2 times, most recently from 2316b78 to 2efbe2c Compare June 12, 2023 20:03
@jerelmiller
Copy link
Member Author

The failing Node 20 test seems to be related to the 20.3 image released on June 9th. There is a PR up to use 20.2 which makes this work: #306. Since this is working as expected, I'm going to go ahead and merge this PR and pull in those other changes when they are ready.

@jerelmiller jerelmiller merged commit 3057433 into glasser/persisted-query-lists Jun 12, 2023
@jerelmiller jerelmiller deleted the file-name-anonymous-operation branch June 12, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant