Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

[DO NOT MERGE] Support APOLLO_KEY in favor of ENGINE_API_KEY #822

Closed
wants to merge 1 commit into from

Conversation

zionts
Copy link
Contributor

@zionts zionts commented Mar 27, 2020

We are moving to a new key format (the prior format of ENGINE_API_KEY
will still work, but will provide a deprecation notice). This commit
updates all non-engineproxy references to refer to APOLLO_KEY instead of
ENGINE_API_KEY.

Blocked by release of apollographql/apollo-tooling#1851
Blocked by release of apollographql/apollo-server#3923
Related to #823
as well as release of <APOLLO_SERVER_PR_HERE>

This still has some steps left, but I wanted to open it up to make sure I'm
tracking all the right ones!

TODO:

  • Update any related Apollo Server docs
  • Include notice about older versions of Apollo Server (e.g. if you're using a version pre-2.9.1, please set ENGINE_API_KEY instead)
  • Get associated CLI and Apollo Server pieces released

We are moving to a new key format (the prior format of ENGINE_API_KEY
will still work, but will provide a deprecation notice). This commit
updates all non-engineproxy references to refer to APOLLO_KEY instead of
ENGINE_API_KEY
@zionts zionts requested a review from StephenBarlow as a code owner March 27, 2020 21:42
@zionts zionts changed the title Replace most references of ENGINE_API_KEY [DO NOT MERGE] Replace most references of ENGINE_API_KEY Mar 27, 2020
@zionts zionts changed the title [DO NOT MERGE] Replace most references of ENGINE_API_KEY [DO NOT MERGE] Support APOLLO_KEY in favor of ENGINE_API_KEY Mar 28, 2020
@zionts
Copy link
Contributor Author

zionts commented May 14, 2020

Closing in favor of #878

@zionts zionts closed this May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant