-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added caveats section to TN0012 #768
Conversation
✅ Deploy Preview for apollo-monodocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/content/technotes/TN0012-namespacing-by-separation-of-concern.mdx
Outdated
Show resolved
Hide resolved
src/content/technotes/TN0012-namespacing-by-separation-of-concern.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Shane Myrick <shane@apollographql.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing this, I think a caveats section is a wise and straightforward solution. I'd also like to suggest that you comment near the top that this caveat exists, e.g. "Please note: this technote isn't fully in compliance with the GraphQL specification as it currently stands, please review the Caveats section for more information."
I've left some further suggestions below.
Thanks again!
src/content/technotes/TN0012-namespacing-by-separation-of-concern.mdx
Outdated
Show resolved
Hide resolved
src/content/technotes/TN0012-namespacing-by-separation-of-concern.mdx
Outdated
Show resolved
Hide resolved
src/content/technotes/TN0012-namespacing-by-separation-of-concern.mdx
Outdated
Show resolved
Hide resolved
…ern.mdx Co-authored-by: Benjie <benjie@jemjie.com>
…ern.mdx Co-authored-by: Benjie <benjie@jemjie.com>
…ern.mdx Co-authored-by: Benjie <benjie@jemjie.com>
No description provided.