Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of 'cannot use in operator' type error shown in development #108

Merged
merged 2 commits into from
May 24, 2022

Conversation

mayakoneval
Copy link
Contributor

This is showing up on code sandbox examples, bad look!

This PR:

  • checks if data is an object & if data.name exists before doing anything else :)

image

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2022

🦋 Changeset detected

Latest commit: ae133ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/explorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mayakoneval mayakoneval requested a review from cheapsteak May 24, 2022 19:24
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ae133ff:

Sandbox Source
npm-embeddable-explorer Configuration

Copy link
Member

@cheapsteak cheapsteak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mayakoneval mayakoneval merged commit 7c741b8 into main May 24, 2022
@mayakoneval mayakoneval deleted the maya/fix-onPostMessageReceived-type-error branch May 24, 2022 20:28
@github-actions github-actions bot mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants