Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(required-fields): don't throw on non-existent field #65

Merged
merged 3 commits into from
May 24, 2017
Merged

fix(required-fields): don't throw on non-existent field #65

merged 3 commits into from
May 24, 2017

Conversation

benjie
Copy link
Contributor

@benjie benjie commented May 24, 2017 •
edited
Loading

Fixes #63

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the README

@jnwng jnwng merged commit 6057cb6 into apollographql:master May 24, 2017
@jnwng
Copy link
Contributor

jnwng commented May 24, 2017

thank you!

@jnwng
Copy link
Contributor

jnwng commented May 24, 2017

this is now available in v0.8.1

jnwng pushed a commit that referenced this pull request May 31, 2017
@benjie @jnwng
fix(required-fields): don't throw on non-existent field (#65)
a37e7f0 
* Do not throw when referencing non-existent attr

* Test to reproduce thrown error

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjie @jnwng