Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 'literal' env, don't validate that fragments exist or are used #70

Merged
merged 1 commit into from
May 29, 2017

Conversation

jtschulz
Copy link
Contributor

@jtschulz jtschulz commented May 26, 2017

Literal .graphql file imports are not properly reconciled, and the KnownFragmentNames and NoUnusedFragment rules will fail. This removes them from the default rules for the literal env. This is a band-aid toward #69

Note: Did not see any tests for the default rules used by envs (tests for literal generally). Happy to provide test coverage, but please advise on what kind of test you'd like to see for this :)

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the README

@apollo-cla
Copy link

@PepperTeasdale: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Literal .graphql file imports are not properly reconciled, and the KnownFragmentNames and NoUnusedFragment rules will fail. This removes them from the default rules for the literal env.
@jtschulz jtschulz force-pushed the update-literal-validators branch from 8fba10a to 2cade0f Compare May 26, 2017 22:44
@jtschulz jtschulz changed the title WIP - Remove failing validators from literal env Remove failing validators from literal env May 26, 2017
@stubailo
Copy link
Contributor

I think this is a good improvement, since probably very few people will actually have all of the fragments in the same file. People who want to configure otherwise can always add the rule explicitly!

@stubailo stubailo changed the title Remove failing validators from literal env In 'literal' env, don't validate that fragments exist or are used May 29, 2017
@stubailo stubailo merged commit 92ce33e into apollographql:master May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants