Add support for .graphqlconfig #80
Conversation
|
@RomanGotsiy: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
awesome @RomanGotsiy! this addresses one of our oldest issues, #8. let me just confirm that this does what we expect with our existing configuration options, and i'll cut a release soon thereafter |
|
@jnwng amazing! Thanks for the update! |
|
Any update on this @jnwng? 🙂 |
src/index.js
Outdated
| @@ -120,14 +128,11 @@ export const rules = { | |||
| }, | |||
| }, | |||
| // schemaJson, schemaJsonFilepath and schemaString are mutually exclusive: | |||
| oneOf: [{ | |||
| required: ['schemaJson'], | |||
| allOf: [{ | |||
There was a problem hiding this comment.
something is a little off about this configuration validation. my assumption is that projectName should be mutually exclusive with schemaJson, schemaString, and schemaJsonFilepath, so this configuration validation should reflect that.
additionally, we'd like to make sure that those validations only happen when those configuration properties are present, and if they're not present, it should still be valid.
there's also a section here that i think needs to match this configuration as well. can we just extract this configuration key validation and use it for all the rules?
|
hey @jnwng Just updated PR according to your requirements |
|
thank you @RomanGotsiy! |
Add support for
.graphqlconfigThis PR is backward compatible as it doesn't remove any already existed configuration options. It just adds support for
.graphqlconfigas a way to configure schema.That's why I made
schemaJson,schemaStringandschemaJsonFilepathnot required (but they still are mutually exclusive)cc @jnwng