Fix escaping of literal .graphql files #88
Conversation
| const expected = 'ESLintPluginGraphQLFile`query { someValueWith\\` }`'; | ||
| it('should wrap with backticks, escape properly and prepend internalTag', () => { | ||
| const query = 'query { search(q: "` \\n ${}") { title } }'; | ||
| const expected = 'ESLintPluginGraphQLFile`query { search(q: "\\` \\\\n \\${}") { title } }`'; |
There was a problem hiding this comment.
as a general comment i think this addition would be clearer as its own test case — im having some trouble parsing what's actually being added here
There was a problem hiding this comment.
What I did here is:
- Updated the test description. This could have been done as a separate commit – the first commit, since the updated test description is valid for the old test as well.
- Beefed up the test case with more stuff that needs escaping than backticks.
So I don't see how a separate test case would make sense :)
There was a problem hiding this comment.
just to double-check here - the \\n is getting escaped as \\\\n but is \\n the already escaped version of \n?
There was a problem hiding this comment.
Welcome to backslash hell :) I have dealt with this in several projects such as CoffeeScript and Prettier :)
The real input is:
query { search(q: "` \n ${}") { title } }
and the real output is:
ESLintPluginGraphQLFile`query { search(q: "\` \\n \${}") { title } }`
|
Btw, this PR is about making a template literal correctly (with correct escaping) for correctness sake. Things do break if someone has |
TODO: