This repository has been archived by the owner on May 3, 2024. It is now read-only.
Second half of updating federation-next to use apollo-compiler@1.0.0-beta.6
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachindshinde
force-pushed
the
sachin/apollo-compiler@1.0.0-beta.6-part-2
branch
from
9723442 to
7ab7ab5
Compare
SimonSapin
approved these changes
Nov 13, 2023
| @@ -53,6 +53,12 @@ impl From<FederationSpecError> for SubgraphError { | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) fn graphql_name_or_subgraph_error(name: &str) -> Result<Name, SubgraphError> { | |||
There was a problem hiding this comment.
The ? operator converts between error types implicitly, so this function can be replaced with impl From<InvalidNameError> for SubgraphError.
… except InvalidNameError does not contain the input string, but we can fix that in apollo-compiler.
There was a problem hiding this comment.
Yeah, that was the main reason I didn't just impl From<InvalidNameError> for the error kinds. Added some TODOs there, lemme know when InvalidNameError is updated and I'll make the switch!
…e invalid name string
sachindshinde
force-pushed
the
sachin/apollo-compiler@1.0.0-beta.6-part-2
branch
from
04896dc to
af1d32d
Compare
SimonSapin
pushed a commit
to apollographql/router
that referenced
this pull request
May 3, 2024
….0-beta.6` (apollographql/federation-next#86) This PR is the second half of apollographql/federation-next#85 , and fully updates `federation-next` to work with `apollo-compiler@1.0.0-beta.6`. Some notes: - This is mainly replacing `&str` with `Name`, and converting some functions to use `Result`s. - The other notable changes are that types (e.g. `ObjectType`) need a `name` field now (making it consistent with the rest of the schema elements in `apollo-rs`), and some minor renames. - Clippy warns that since `NodeStr` doesn't have `#[derive(PartialEq, Eq)]`, then we can't use `Name` in pattern-matching; I've worked around it with an enum and map for now. - Consolidated a bit of the logic around converting subgraph names to enum values, with a `TODO` around doing what the JS codebase does. - Unrelated, but I've been told we had some usages of `.eq()` in the Rust code, so I've converted them to `==`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second half of #85 , and fully updates
federation-nextto work withapollo-compiler@1.0.0-beta.6.Some notes:
&strwithName, and converting some functions to useResults.ObjectType) need anamefield now (making it consistent with the rest of the schema elements inapollo-rs), and some minor renames.NodeStrdoesn't have#[derive(PartialEq, Eq)], then we can't useNamein pattern-matching; I've worked around it with an enum and map for now.TODOaround doing what the JS codebase does..eq()in the Rust code, so I've converted them to==.