chore(deps): update dependency apollo-server to v2.24.0 #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
![renovate-approve[bot]](https://avatars.githubusercontent.com/in/7394?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/apollo-server-2.x
branch
from
ffb0a93
to
7c6369b
Compare
glasser
added a commit
that referenced
this pull request
May 3, 2021
Something like this was intended to be part of #453. Because we have `diagnostics: false` in jest.config.base.js, typechecking failures in ts-jest don't actually stop the tests from running successfully; this change makes us typecheck the tests before we run them. (If you really want to run tests that don't typecheck you can run `npx jest` directly.) As part of this, fix a typechecking failure caused by the upgrade in PR #716 and run `npm dedup` to fix another one. We may want to consider finding a way to be comfortable removing `diagnostics: false` instead.
glasser
added a commit
that referenced
this pull request
May 3, 2021
Something like this was intended to be part of #453. Because we have `diagnostics: false` in jest.config.base.js, typechecking failures in ts-jest don't actually stop the tests from running successfully; this change makes us typecheck the tests before we run them. (If you really want to run tests that don't typecheck you can run `npx jest` directly.) As part of this, fix a typechecking failure caused by the upgrade in PR #716 and run `npm dedup` to fix another typechecking failure. The `npm dedup` itself causes a snapshot to need to be updated (as the snapshot was created by some code that was still running a nested apollo-server 2.23). We may want to consider finding a way to be comfortable removing `diagnostics: false` instead as in #661, but we'll need to fix #662 before we can do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.23.0->2.24.0Release Notes
apollographql/apollo-server
v2.24.0Compare Source
apollo-server-core: Apollo Studio usage reporting uses a more efficient format which sends fewer detailed traces to Apollo's server. This change should not have a major effect on the experience of using Apollo Studio. PR #4142Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Enabled.
♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.