Make WithFilter output type compatible with Apollo Server subscriptions #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AsyncIterableIterator to match subscription type
|
This is a rework of #275. |
glasser
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
OK, I think this makes sense. It's just promising that withFilter will return something that's doubly-useful — something you can use in an API expecting an Iterable or an API expecting an Iterator.
The WithFilter type is a bit weird — it seems like you could just use typeof<withFilter> instead or something. But I think that makes sense too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscriptions require an AsyncIterable, but withFilter was returning an AsyncIterator. This updates the type of withFilter to acknowledge it returns a type which is both an AsyncIterable and an AsyncIterator.