Add "type": "module" #254
Merged
Add "type": "module" #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benmccann: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
I've signed the CLA. Thanks |
|
@benjamn thanks for approving the workflow. It looks like the tests were failing since adding |
The public package should still work in older versions of Node.js (including v10), but it's a bit annoying to skip the ESM tests in certain Node.js versions.
benjamn
reviewed
Feb 4, 2022
| "mocha": "^9.0.2", | ||
| "mocha": "^9.2.0", |
There was a problem hiding this comment.
Nice catch that mocha@latest supports ESM syntax!
benmccann
commented
Feb 4, 2022
benjamn
approved these changes
Feb 4, 2022
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Feb 4, 2022
Should help with issue #8218, thanks to @benmccann's work in apollographql/invariant-packages#254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help add SvelteKit / Vite support (apollographql/apollo-client#8218)
Closes #240
Closes #227