Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

added meaningful error for variable mismatch and caught a number of f… #3614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added meaningful error for variable mismatch and caught a number of f… #3614

wants to merge 1 commit into from

Conversation

chanceeakin
Copy link

@chanceeakin chanceeakin commented Oct 20, 2019

…laky tests

Description:

MockedProvider is incredibly useful, but its error messages are terse and most fall under the 'no more mocked responses.' Most often, this error is because of a variable mismatch. I added an explicit error for variables mismatches, as well as found some flaky tests relying on a lack of meaningful errors.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

@apollo-cla
Copy link

@chanceeakin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@chanceeakin
Copy link
Author

chanceeakin commented Oct 20, 2019

Hey, this PR is currently failing; uncovered some flaky tests with the addition of the error. Marked them in the PR and would love some help with resolving them.😄

For reference: #3481.

@piotrd
Copy link

piotrd commented Mar 17, 2020

Any updates on this one by chance?

@chanceeakin
Copy link
Author

@piotrd Not that I've seen. 🤷‍♂️Wanna give it a bump?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants