fix(graphql-types): graphql-tag binding for default export

[emmenko]

Labels:

• bug

Description

Fix bindings for the default export of graphql-tag

Instead it should be

var graphqlMutationAST = GraphqlTag.default(Config[/* query */0]);

[Gregoirevda]

This is the exact same thing: https://bucklescript.github.io/docs/en/import-export.html

[baldurh]

They seem to have updated the docs showing the difference: https://bucklescript.github.io/docs/en/import-export.html#import-an-es6-default-value

[Gregoirevda]

Do you have

{
/* ... */
"package-specs": [
    {
      "module": "commonjs",
    }
  ],
}

in your bsconfig.json?

[emmenko]

Ah yeah I have "module": "es6".

Hmm, is there anything we can do to support both? 🤔 Actually both are supported (see comment below).

[Gregoirevda]

Does this fixes the problem?
[@bs.module "graphql-tag"] external gql : ReasonApolloTypes.gql = "default";

I'd find it strange cause it should really be exactly the same.

[emmenko]

Yes this fixes it.

If you look at graphql-tag, it explicitly exports default, so this binding should work in both commonjs and es6.

What do you think?

[Gregoirevda]

The creator of Bucklescript told me ES6 default import support was not merged in master yet. Let's wait a bit more

[emmenko]

Should we merge the fix first and refactor it once BS has support for that?

Everyone who uses ES6 currently can’t use this library. I understand your point but I find this bug fix important.
Can we maybe publish this under next as well?

[Gregoirevda]

Sure, I'll do that this evening ;)

[emmenko]

@Gregoirevda any update on this one?

[lecler-i]

Hello, any updates on this one ? The patch works well in my case.. would love to have this released :-)

[Gregoirevda]

This is still an issue for "module": "es6" ?

[baldurh]

This is still an issue for "module": "es6" ?

@Gregoirevda yes. I’m battling this currently.

The docs show different examples of importing default and ES6 (babel) default:
https://bucklescript.github.io/docs/en/interop-cheatsheet#import-default

[Gregoirevda]

Is this still an issue? I believe Buckescript now has support for default export...?
Should it be external myFunction : unit -> unit = "my-module" [@@bs.default]

[baransu]

@Gregoirevda Is @bs.default documented anywhere? I cannot find it.

[Gregoirevda]

Can someone confirm this is fixed with es6 modules?
We actually already have this PR merged from another one. What we use is
[@bs.module "graphql-tag"] external gql: gql = "default";
Instead of [@bs.module] external gql: gql = "graphql-tag";

@baransu I was referring to: rescript-lang/rescript-compiler#2677 (comment) which might be outdated