Make test_experimental_notice more targeted in its assertions so th…

…at it won't fail on other output changes.

.changesets/maint_niece_lift_screwdriver_baton.md

@@ -0,0 +1,6 @@
+### Make test_experimental_notice assertion more targeted ([Issue #ISSUE_NUMBER](https://github.com/apollographql/router/pull/3036))
+
+Previously this test relied on a full snapshot of the log. This is likely to result in failures either due to environmental reasons or other unrelated changes.
+The test now relies on a more targeted assertion that is less likely to fail.
+
+By [@bryncooke](https://github.com/bryncooke) in https://github.com/apollographql/router/pull/3036

apollo-router/tests/common.rs

@@ -411,7 +411,7 @@ impl IntegrationTest {
     }
 
     #[allow(dead_code)]
-    async fn assert_log_contains(&mut self, msg: &str) {
+    pub async fn assert_log_contains(&mut self, msg: &str) {
         let now = Instant::now();
         while now.elapsed() < Duration::from_secs(5) {
             if let Ok(line) = self.stdio_rx.try_recv() {

apollo-router/tests/lifecycle_tests.rs

@@ -185,7 +185,6 @@ async fn test_cli_config_preview() {
 
 #[tokio::test(flavor = "multi_thread")]
 async fn test_experimental_notice() {
-    let (tx, rx) = tokio::sync::oneshot::channel();
     let mut router = IntegrationTest::builder()
         .config(
             "
@@ -194,12 +193,12 @@ async fn test_experimental_notice() {
                     format: json
             ",
         )
-        .collect_stdio(tx)
         .build()
         .await;
     router.start().await;
+    router
+        .assert_log_contains("You're using some \\\"experimental\\\" features of the Apollo Router")
+        .await;
     router.assert_started().await;
     router.kill().await;
-
-    insta::assert_snapshot!(rx.await.unwrap());
 }