Skip to content

Commit

Permalink
update Rhai to 1.15.0 to fix issue with hanging example test (#3273)
Browse files Browse the repository at this point in the history
One of our Rhai examples' tests have been regularly hanging in the CI
builds for the last couple of months. Investigation uncovered a race
condition within Rhai itself. This update brings in the fixed version of
Rhai and should eliminate the hanging problem.

fixes: #3213
  • Loading branch information
garypen authored Jun 19, 2023
1 parent 2e1d8bd commit 0f23acc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changesets/maint_garypen_3213_subgraph_cache.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### update Rhai to 1.15.0 to fix issue with hanging example test ([Issue #3213](https://github.com/apollographql/router/issues/3213))

One of our Rhai examples' tests have been regularly hanging in the CI builds for the last couple of months. Investigation uncovered a race condition within Rhai itself. This update brings in the fixed version of Rhai and should eliminate the hanging problem and improve build stability.

By [@garypen](https://github.com/garypen) in https://github.com/apollographql/router/pull/3273
4 changes: 2 additions & 2 deletions Cargo.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4822,9 +4822,9 @@ dependencies = [

[[package]]
name = "rhai"
version = "1.14.0"
version = "1.15.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "b2c99b27f6661b4d217b6aa21727c6a0808729266edfc8a8877042d609b1904e"
checksum = "778dd6094c66d4e31cd7b28533aa38af6379e8bbc4fe7aedcb3ed83aa6dc315a"
dependencies = [
"ahash 0.8.3",
"bitflags",
Expand Down
3 changes: 2 additions & 1 deletion apollo-router/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ prost = "0.11.9"
prost-types = "0.11.9"
proteus = "0.5.0"
rand = "0.8.5"
rhai = { version = "1.14.0", features = ["sync", "serde", "internals"] }
rhai = { version = "1.15.0", features = ["sync", "serde", "internals"] }
regex = "1.8.4"
reqwest = { version = "0.11.18", default-features = false, features = [
"rustls-tls",
Expand Down Expand Up @@ -249,6 +249,7 @@ reqwest = { version = "0.11.18", default-features = false, features = [
"json",
"stream",
] }
rhai = { version = "1.15.0", features = ["sync", "serde", "internals", "testing-environ"] }
similar-asserts = "1.4.2"
tempfile = "3.6.0"
test-log = { version = "0.2.12", default-features = false, features = [
Expand Down

0 comments on commit 0f23acc

Please sign in to comment.