Skip to content

Commit

Permalink
add a changeset
Browse files Browse the repository at this point in the history
  • Loading branch information
garypen committed Jun 6, 2024
1 parent 0de1700 commit 1f2fb32
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .changesets/feat_garypen_router_340_extensions_with_lock.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
### Add Extensions with_lock() to try and avoid timing issues ([PR #5360](https://github.com/apollographql/router/pull/5360))

It's easy to trip over issues when interacting with Extensions because we inadvertently hold locks for too long. This can be a source of bugs in the router and causes a lot of tests to be flaky.

with_lock() avoids this kind of problem by explicitly restricting the lifetime of the Extensions lock.

By [@garypen](https://github.com/garypen) in https://github.com/apollographql/router/pull/5360

0 comments on commit 1f2fb32

Please sign in to comment.