Skip to content

Commit

Permalink
fixed a (type-position, schema) inconsistency in `compute_nodes_for_k…
Browse files Browse the repository at this point in the history
…ey_resolution` (#5435)

Partially fixes https://apollographql.atlassian.net/browse/FED-251
  • Loading branch information
duckki authored and Meschreiber committed Jun 17, 2024
1 parent 085d924 commit c4036af
Showing 1 changed file with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,11 @@ fn only_uses_an_interface_object_if_it_can() {
}

#[test]
#[should_panic(
expected = "Cannot add selection of field \"I.__typename\" to selection set of parent type \"I\" that is potentially an interface object type at runtime"
)]
// TODO: investigate this failure
// - Fails to rebase on an interface object type in a subgraph.
fn does_not_rely_on_an_interface_object_directly_for_typename() {
let planner = planner!(
S1: SUBGRAPH1,
Expand Down Expand Up @@ -226,9 +231,11 @@ fn does_not_rely_on_an_interface_object_directly_for_typename() {
#[test]
#[should_panic(
expected = r#"Cannot add selection of field "I.id" to selection set of parent type "A""#
expected = r#"Cannot add selection of field "I.id" to selection set of parent type "A""#
)]
// TODO: investigate this failure
// - Fails to rebase on an interface object type in a subgraph.
// - Fails to rebase on an interface object type in a subgraph.
fn does_not_rely_on_an_interface_object_directly_if_a_specific_implementation_is_requested() {
let planner = planner!(
S1: SUBGRAPH1,
Expand Down Expand Up @@ -429,9 +436,11 @@ fn handles_query_of_an_interface_field_for_a_specific_implementation_when_query_
#[test]
#[should_panic(
expected = r#"Cannot add selection of field "I.id" to selection set of parent type "A""#
expected = r#"Cannot add selection of field "I.id" to selection set of parent type "A""#
)]
// TODO: investigate this failure
// - Fails to rebase on an interface object type in a subgraph.
// - Fails to rebase on an interface object type in a subgraph.
fn it_avoids_buffering_interface_object_results_that_may_have_to_be_filtered_with_lists() {
let planner = planner!(
S1: r#"
Expand Down

0 comments on commit c4036af

Please sign in to comment.