Remove delay_interval in telemetry configuration (#1498)

It does nothing. It was added in 74b20a3 / #782 and was already doing nothing then. I haven’t found someone who can guess what it might have been meant to be.
apollographql · Aug 11, 2022 · f0267de · f0267de
1 parent eab203d
commit f0267de
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 24 deletions.
diff --git a/NEXT_CHANGELOG.md b/NEXT_CHANGELOG.md
@@ -23,10 +23,26 @@ Description! And a link to a [reference](http://url)
 By [@USERNAME](https://github.com/USERNAME) in https://github.com/apollographql/router/pull/PULL_NUMBER
 -->
 
-# [0.15.1] (unreleased) - 2022-mm-dd
+# [0.16] (unreleased) - 2022-mm-dd
 
 ## ❗ BREAKING ❗
 
+### Removed `delay_interval` in telemetry configuration. [PR #FIXME]
+
+It was doing nothing.
+
+```yaml title="router.yaml"
+telemetry:
+  metrics:
+    common:
+      # Removed, will now cause an error on Router startup:
+      delay_interval:
+        secs: 9
+        nanos: 500000000
+```
+
+By [@SimonSapin](https://github.com/SimonSapin)
+
 ## 🚀 Features
 
 ### Add support of global rate limit and timeout. [PR #1347](https://github.com/apollographql/router/pull/1347)

diff --git a/...r/src/configuration/snapshots/apollo_router__configuration__tests__schema_generation.snap b/...r/src/configuration/snapshots/apollo_router__configuration__tests__schema_generation.snap
@@ -1,6 +1,5 @@
 ---
 source: apollo-router/src/configuration/mod.rs
-assertion_line: 914
 expression: "&schema"
 ---
 {
@@ -1275,26 +1274,6 @@ expression: "&schema"
                   "additionalProperties": false,
                   "nullable": true
                 },
-                "delay_interval": {
-                  "type": "object",
-                  "required": [
-                    "nanos",
-                    "secs"
-                  ],
-                  "properties": {
-                    "nanos": {
-                      "type": "integer",
-                      "format": "uint32",
-                      "minimum": 0.0
-                    },
-                    "secs": {
-                      "type": "integer",
-                      "format": "uint64",
-                      "minimum": 0.0
-                    }
-                  },
-                  "nullable": true
-                },
                 "resources": {
                   "description": "Resources",
                   "default": {},

diff --git a/apollo-router/src/plugins/telemetry/config.rs b/apollo-router/src/plugins/telemetry/config.rs
@@ -1,7 +1,6 @@
 //! Configuration for the telemetry plugin.
 use std::borrow::Cow;
 use std::collections::BTreeMap;
-use std::time::Duration;
 
 use opentelemetry::sdk::Resource;
 use opentelemetry::Array;
@@ -59,7 +58,6 @@ pub struct Metrics {
 #[derive(Clone, Default, Debug, Deserialize, JsonSchema)]
 #[serde(deny_unknown_fields, rename_all = "snake_case")]
 pub struct MetricsCommon {
-    pub delay_interval: Option<Duration>,
     /// Configuration to add custom labels/attributes to metrics
     pub attributes: Option<MetricsAttributesConf>,
     #[serde(default)]