Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API 1.0 - ApolloRouterBuilder revisit #1148

Closed
3 tasks done
Tracked by #1131
BrynCooke opened this issue May 24, 2022 · 0 comments · Fixed by #1227, #1239, #1234 or #1263
Closed
3 tasks done
Tracked by #1131

API 1.0 - ApolloRouterBuilder revisit #1148

BrynCooke opened this issue May 24, 2022 · 0 comments · Fixed by #1227, #1239, #1234 or #1263
Assignees
@BrynCooke

Comments

@BrynCooke
Copy link
Contributor

BrynCooke commented May 24, 2022 •
edited
Loading

ApolloRouterBuilder needs revisiting. In particular the state_receiver should be required to spawn a thread rather than the weird join stuff that happens right now.

  • Migrate to BuildStructor
  • Remove state_receiver
  • Factor out startup functionality
@BrynCooke BrynCooke mentioned this issue May 24, 2022
Closed
19 tasks
@BrynCooke BrynCooke changed the title API 1.0 - Entry point state change listener API 1.0 - ApolloRouterBuilder revisit May 24, 2022
@BrynCooke BrynCooke self-assigned this Jun 13, 2022
This was linked to pull requests Jun 14, 2022
Entry point improvements #1227
Merged
Remove rt_main #1239
Merged
Rename FederatedServerError to ApolloRouterError #1234
Merged
@BrynCooke BrynCooke linked a pull request Jun 16, 2022 that will close this issue
Make Executable::builder() async #1263
Merged
This was referenced Jun 17, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrynCooke BrynCooke

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@BrynCooke