api 1.0 phase 1 #1274
Closed
api 1.0 phase 1 #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It had become the same as the crate root.
Co-authored-by: bryn <bryn@apollographql.com>
* Modify the async checkpoint signature to reduce boxing. The current implementation required the provided callback to be boxed. This change removes that requirement. It requires more generics, but that is the trade off.
Merge includes Defer enhancements.
Just spotted a redundant Box::pin() which crept back in during the merge, so removing it.
* Removed ApolloRouterBuilder in favor of buildstructor. * Entry point improvements `ApolloRouterBuilder` has been migrated to `buildstructor` for consistency with other code. Calls to `ApolloRouterBuilder::default()` should be migrated to `ApolloRouter::builder`. `FederatedServerHandle` has been renamed to `ApolloRouterHandle`. Removed functionality: * The ability to supply your own `RouterServiceFactory`. This may be added back if there is a concrete use case for it. * `StateListener`. This made the internal state machine unnecessarily complex. `ready()` remains on `ApolloRouterHandle`. * `ApolloRouterHandle#shutdown()` has been removed. Instead dropping `ApolloRouterHandle` will cause the router to shutdown. Co-authored-by: bryn <bryn@apollographql.com>
Co-authored-by: bryn <bryn@apollographql.com>
This is part #1217 but we may want to go further still. This replaces all occurrences of `pub use some_module::*;` in the root of the `apollo-router` crate with a combination of: 1. Changing users to import from `some_module` instead (sometimes making that module public) 2. `pub use` of some specific items because they make sense there 3. `pub use` or `pub(crate) use` of some specific items because there are very many users and this PR is already too big 4. `pub(crate) use some_module::*;` because there are very many items and users, and this PR is already too big
* add support for modifying request variables from a plugin Native or rhai.
Make Executable::builder() async Co-authored-by: bryn <bryn@apollographql.com>
This fixes some of the warnings emitted by `cargo doc`. Remaining warnings involve either making some types public, or removing mentions of them in public docs and in some cases making fields private. See: #1150 (comment)
I meant this to be part of #1271 and messed up my commit amend
Some reexports where recently removed, making some items unreachable from other crates as they are defined in private modules. This changes such items from `pub` to `pub(crate)` in order to better communicate the situation to human readers, and enables warnings for the `unreachable_pub` lint. The diff is mostly generated by `cargo fix` with this lint.
timing problems...
✅ Deploy Preview for apollo-router-docs canceled.
|
|
we should get #1233 in api-1.0 before merging this PR |
* move the query cache into the query planner * move introspection in the query planner * keep the known introspection queries but remove the mutable introspection cache we pregenerate introspection responses for known queries, but we will rely on the caching query planner to store all the actually received introspection queries * remove QueryCache we are now relying on the caching query planner Co-authored-by: Gary Pennington <gary@apollographql.com>
|
Closing this draft as we are now about to raise the real api-1.0 (phase 1) merge PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft PR so that people can see what's coming...
fix: #1146, #1148, #1151, #1141