Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0: apollo_router::plugin::Handler #1481

Closed
abernix opened this issue Aug 9, 2022 · 1 comment
Closed

v1.0: apollo_router::plugin::Handler #1481

abernix opened this issue Aug 9, 2022 · 1 comment
Assignees

Comments

@abernix
Copy link
Member

abernix commented Aug 9, 2022

In the docs this is described as: "Handler represents a Plugin endpoint.". We started discussing whether this comment was correct or not and were discussing whether the Handler should be renamed to PluginEndpoint or just Endpoint.

Some assessment suggests that the comment might be wrong, but that turned into a different proposal that we believe is worth chasing:

The proposal here is that it becomes private. For plugins that still want to do this, the plugin can simply return a box service rather than returning a handler created from a box service. The original design seems to suggest (@bnjjj may be able to a provide a link to context here) that we introduced the previous pattern because of a constraint imposed by Warp, that is no longer necessary with our change to Axum.

@abernix abernix added the api/1.0 label Aug 9, 2022
@bnjjj
Copy link
Contributor

bnjjj commented Aug 9, 2022

Related comment #738 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants