Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introspection: Change the caching behavior #1516

Closed
o0Ignition0o opened this issue Aug 16, 2022 · 1 comment · Fixed by #1517
Closed

Introspection: Change the caching behavior #1516

o0Ignition0o opened this issue Aug 16, 2022 · 1 comment · Fixed by #1517
Assignees
@o0Ignition0o

Comments

@o0Ignition0o
Copy link
Contributor

o0Ignition0o commented Aug 16, 2022 •
edited
Loading

Since @bnjjj s refactoring of introspection, we don't need to cache every introspection query we know of anymore.

Moreover it causes the router to use quite a fair bit of memory when introspection is enabled.

Now would be a great time to remove it from the codebase, and add a simple LRU introspection cache with TTL.
@o0Ignition0o o0Ignition0o changed the title Introspection: Remove the cache Introspection: Change the caching behavior Aug 16, 2022
@abernix
Copy link
Member

abernix commented Aug 16, 2022

Sounds good. Per our conversation, suggest a low capacity LRU with no TTL since introspection is tied to the life-time of the schema.

o0Ignition0o added a commit that referenced this issue Aug 16, 2022
@o0Ignition0o
feature: introspection: don't prefill the introspection cache anymore.
6fbc9c2 
fixes: #1516, #1466

Since @bnjjj s refactoring on introspection, we don't need to cache well known introspection queries.

Pros: Caching those queries and responses can lead to high memory footprints, especially on very large schemas.
Cons: The first introspection query will take a bit longer (~130ms on my machine) than the cached one (~2ms on my machine)

The default introspection cache size is now 5, and cannot be configured. 5 has been chosen because we do not expect local developers to run tools that need more than 5 different introspection queries with < 3ms latency requirements.
@o0Ignition0o o0Ignition0o mentioned this issue Aug 16, 2022
Merged
@o0Ignition0o o0Ignition0o self-assigned this Aug 16, 2022
o0Ignition0o added a commit that referenced this issue Aug 17, 2022
@o0Ignition0o
feature: introspection: don't prefill the introspection cache anymore. (
a366da9 
#1517)



fixes: #1516, #1466

Since @bnjjj s refactoring on introspection, we don't need to cache well known introspection queries.

Pros: Caching those queries and responses can lead to high memory footprints, especially on very large schemas.
Cons: The first introspection query will take a bit longer (~130ms on my machine) than the cached one (~2ms on my machine)

The default introspection cache size is now 5, and cannot be configured. 5 has been chosen because we do not expect local developers to run tools that need more than 5 different introspection queries with < 3ms latency requirements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@o0Ignition0o o0Ignition0o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: introspection: don't prefill the introspection cache anymore. apollographql/router
2 participants
@abernix @o0Ignition0o