Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add namespacing to redis keys #4247

Closed
Geal opened this issue Nov 21, 2023 · 2 comments · Fixed by #4458
Closed

add namespacing to redis keys #4247

Geal opened this issue Nov 21, 2023 · 2 comments · Fixed by #4458
Assignees
@Geal
Labels
component/cache

Comments

@Geal
Copy link
Contributor

Geal commented Nov 21, 2023

it would allow authorization based on a prefix, for multitenant clusters
@Geal Geal mentioned this issue Nov 22, 2023
Merged
6 tasks
@BrynCooke
Copy link
Contributor

Just been reading and the term in the the redis docs is keyspace, so let's align around that.

@Geal
Copy link
Contributor Author

Geal commented Jan 11, 2024

keyspace refers to the entire set of keys. Namespace is commonly used in Redis, and well understood elsewhere https://redis.com/blog/5-key-takeaways-for-developing-with-redis/

@Geal Geal mentioned this issue Jan 11, 2024
Merged
6 tasks
Geal added a commit that referenced this issue Jan 17, 2024
@Geal
Redis key namespace (#4458)
842efa6 
Fix [#4247](#4247)
Fix [#3765](#3765)

This adds an optional prefix to redis keys
garypen pushed a commit that referenced this issue Jan 17, 2024
@Geal @garypen
Redis key namespace (#4458)
5814402 
Fix [#4247](#4247)
Fix [#3765](#3765)

This adds an optional prefix to redis keys
@garypen garypen mentioned this issue Jan 18, 2024
Closed
@abernix abernix mentioned this issue Jan 19, 2024
Merged
Meschreiber pushed a commit that referenced this issue Feb 1, 2024
@Geal @Meschreiber
Redis key namespace (#4458)
f0276b6 
Fix [#4247](#4247)
Fix [#3765](#3765)

This adds an optional prefix to redis keys
smihica pushed a commit to smihica/router that referenced this issue Feb 17, 2024
@Geal @smihica
Redis key namespace (apollographql#4458)
9286c02 
Fix [apollographql#4247](apollographql#4247)
Fix [apollographql#3765](apollographql#3765)

This adds an optional prefix to redis keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
component/cache
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redis key namespace apollographql/router
2 participants
@Geal @BrynCooke