Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity cache: option to allow starting without a valid Redis connection #4334

Closed
Geal opened this issue Dec 5, 2023 · 0 comments · Fixed by #4534
Closed

Entity cache: option to allow starting without a valid Redis connection #4334

Geal opened this issue Dec 5, 2023 · 0 comments · Fixed by #4534
Assignees
@Geal

Comments

@Geal
Copy link
Contributor

Geal commented Dec 5, 2023

right now, if we get an error when inserting or retrieving data from redis, the query will still be executed normally. But if we can't contact redis on startup, the router won't start. It could be useful to have an option for a fail open start, where the router will still start and serve traffic, even if redis is not available
@Geal Geal self-assigned this Jan 15, 2024
@Geal Geal mentioned this issue Jan 23, 2024
Merged
6 tasks
Geal added a commit that referenced this issue Feb 22, 2024
@Geal
Redis: add a fail open option when starting the Router (#4534)
3381128 
Fix #4334

This option allows the router to start even if we cannot connect to
Redis.
@abernix abernix mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redis: add a fail open option when starting the Router apollographql/router
1 participant
@Geal