Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add options to set the username or password separately for Redis #4346

Closed
Geal opened this issue Dec 7, 2023 · 0 comments · Fixed by #4453
Closed

add options to set the username or password separately for Redis #4346

Geal opened this issue Dec 7, 2023 · 0 comments · Fixed by #4453
Assignees
@bnjjj

Comments

@Geal
Copy link
Contributor

Geal commented Dec 7, 2023

Right now, the Redis username and password are set in the URL, but due to that we run into issues like aembke/fred.rs#186. We could add an option to set the username and password directly. This would also allow the password to be set from environment variables
@bnjjj bnjjj self-assigned this Jan 10, 2024
@bnjjj bnjjj mentioned this issue Jan 10, 2024
Merged
6 tasks
bnjjj added a commit that referenced this issue Jan 12, 2024
@bnjjj
feat(redis): add options to set username and password separately (#4453)
1cd670e 
Example of configuration:

```yaml title="router.yaml"
supergraph:
  query_planning:
    experimental_cache:
      redis: #highlight-line
        urls: ["redis://..."] #highlight-line
        username: admin/123 # Optional, can be part of the urls directly, mainly useful if you have special character like '/' in your password that doesn't work in url
        password: admin # Optional, can be part of the urls directly, mainly useful if you have special character like '/' in your password that doesn't work in url
        timeout: 5ms # Optional, by default: 2ms
        ttl: 24h # Optional, by default no expiration
```

Fixes #4346
---------

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@garypen garypen mentioned this issue Jan 18, 2024
Closed
@abernix abernix mentioned this issue Jan 19, 2024
Merged
smihica pushed a commit to smihica/router that referenced this issue Feb 17, 2024
@bnjjj @smihica
feat(redis): add options to set username and password separately (apo…
8c5c1f5 
…llographql#4453)

Example of configuration:

```yaml title="router.yaml"
supergraph:
  query_planning:
    experimental_cache:
      redis: #highlight-line
        urls: ["redis://..."] #highlight-line
        username: admin/123 # Optional, can be part of the urls directly, mainly useful if you have special character like '/' in your password that doesn't work in url
        password: admin # Optional, can be part of the urls directly, mainly useful if you have special character like '/' in your password that doesn't work in url
        timeout: 5ms # Optional, by default: 2ms
        ttl: 24h # Optional, by default no expiration
```

Fixes apollographql#4346
---------

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(redis): add options to set username and password separately apollographql/router
2 participants
@Geal @bnjjj