Improve JWKS logging to allow debugging of issues during download #4448
Assignees
Comments
BrynCooke
pushed a commit
that referenced
this issue
Jan 9, 2024
Adds a span so that we can correlate log messages, adds debug output for the content of the file. Fixes #4448
6 tasks
BrynCooke
pushed a commit
that referenced
this issue
Jan 9, 2024
Adds a span so that we can correlate log messages, adds debug output for the content of the file. Fixes #4448
BrynCooke
added a commit
that referenced
this issue
Jan 10, 2024
Adds a span so that we can correlate log messages, adds debug output for the content of the file. Fixes #4448 <!-- start metadata --> --- **Checklist** Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review. - [ ] Changes are compatible[^1] - [ ] Documentation[^2] completed - [ ] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. Co-authored-by: bryn <bryn@apollographql.com>
Merged
smihica
pushed a commit
to smihica/router
that referenced
this issue
Feb 17, 2024
Adds a span so that we can correlate log messages, adds debug output for the content of the file. Fixes apollographql#4448 <!-- start metadata --> --- **Checklist** Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review. - [ ] Changes are compatible[^1] - [ ] Documentation[^2] completed - [ ] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. Co-authored-by: bryn <bryn@apollographql.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently it is difficult to figure out what has gone wrong when a JWKS fails to download.
Enabling hyper trace logs is not an acceptable solution as this produces a ton of noise, and because we don't use spans they are difficult to correlate.
The text was updated successfully, but these errors were encountered: