Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panics now output to logs #1001

Merged
merged 2 commits into from
May 10, 2022
Merged

Panics now output to logs #1001

merged 2 commits into from
May 10, 2022

Conversation

BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented May 10, 2022

Previously panics would get swallowed. Now they are output to the logs.
Setting RUST_BACKTRACE=1 or RUST_BACKTRACE=full enables the full backtrace to also be logged.

A warning is output to the logs on startup if RUST_BACKTRACE is set.

@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for apollo-router-docs canceled.

Name Link
🔨 Latest commit 74df594
🔍 Latest deploy log https://app.netlify.com/sites/apollo-router-docs/deploys/627a64c88ae52e00088d194b

Previously panics would get swallowed. Now they are output to the logs.
Setting `RUST_BACKTRACE=1` or `RUST_BACKTRACE=full` enables the full backtrace to also be logged.
@BrynCooke BrynCooke self-assigned this May 10, 2022
@BrynCooke BrynCooke linked an issue May 10, 2022 that may be closed by this pull request
@BrynCooke BrynCooke requested review from garypen and Geal May 10, 2022 12:48
@BrynCooke BrynCooke enabled auto-merge (squash) May 10, 2022 13:19
@BrynCooke BrynCooke merged commit 81eeac5 into main May 10, 2022
@BrynCooke BrynCooke deleted the bryn/panic-handler branch May 10, 2022 13:29
@Geal Geal added this to the v0.9.0-rc.0 milestone May 10, 2022
@Geal Geal mentioned this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APQ test fails occasionally
3 participants