modify Context::upsert()

[garypen]

Remove the default parameter and require upserted values to implement
Default.

fixes: #1070

[netlify]

✅ Deploy Preview for apollo-router-docs ready!

Name	Link
🔨 Latest commit	89fac01
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-router-docs/deploys/6284bd1716164a00083a2dcb
😎 Deploy Preview	https://deploy-preview-1073--apollo-router-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[o0Ignition0o]

This looks great!

I m not sure I'd like to get rid of the ability to perform an upsert with a callback to set the value if there want any, are there drawbacks to keeping the former method and maybe renaming it?

EDIT: nevermind, we re calling the update callback regardless, so it s totally fine

[garypen]

This looks great!

I m not sure I'd like to get rid of the ability to perform an upsert with a callback to set the value if there want any, are there drawbacks to keeping the former method and maybe renaming it?

No one could think of a good reason to provide that ability, so my proposal is that we could always add a upsert_with_default() function (which would be the existing function added back) if we needed it, but no point adding it until we need it.