Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate errors from QueryPlannerResponse::error_new #1358

Closed
wants to merge 1 commit into from
Closed

Propagate errors from QueryPlannerResponse::error_new #1358

wants to merge 1 commit into from

Conversation

SimonSapin
Copy link
Contributor

Fixes #1142

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

@SimonSapin your pull request is missing a changelog!

@SimonSapin SimonSapin mentioned this pull request Jul 5, 2022
Closed
2 tasks
@SimonSapin
Copy link
Contributor Author

Per #1142 (comment) this is not the desired behavior

@SimonSapin SimonSapin closed this Jul 19, 2022
@abernix abernix deleted the simon/query-planne-errors branch March 29, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjjj bnjjj bnjjj approved these changes

@Geal Geal Geal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propagate query planner errors as graphql::Error, not Result::Err
3 participants
@SimonSapin @Geal @bnjjj