Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query_planner): put queryplan options in private and wrap QueryPlanContent in an opaque type #1486

Merged
merged 7 commits into from
Aug 12, 2022

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Aug 9, 2022

No description provided.

…eryPlanContent in an opaque type

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj added the api/1.0 label Aug 9, 2022
@bnjjj bnjjj requested review from Geal and SimonSapin August 9, 2022 15:23
@bnjjj bnjjj self-assigned this Aug 9, 2022
@github-actions

This comment has been minimized.

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
apollo-router/src/services/mod.rs Show resolved Hide resolved
apollo-router/src/services/mod.rs Outdated Show resolved Hide resolved
apollo-router/src/services/mod.rs Outdated Show resolved Hide resolved
apollo-router/src/services/mod.rs Outdated Show resolved Hide resolved
bnjjj added 3 commits August 11, 2022 11:17
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from SimonSapin August 11, 2022 09:20
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from Geal August 11, 2022 15:07
@bnjjj bnjjj merged commit 4ec0bcf into main Aug 12, 2022
@bnjjj bnjjj deleted the bnjjj/refactor_query_planner_struct branch August 12, 2022 09:51
@Geal Geal mentioned this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants