better rhai logging #1521
Merged
better rhai logging #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix versioning of crates...
or things won't build too well.
Many changes in API for testing, so make sure to keep up with them.
The small logging improvements are worth releasing now. The span stuff is not quite fully baked and needs a bit more thought. I'll think about it for a later PR.
This comment has been minimized.
This comment has been minimized.
to describe the new feature
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small ergonomic improvement for rhai logging which makes the the various log functions accept a
Dynamicrather than requiring a&str. This isn't a breaking change, because a rhaiDynamiccan represent any valid rhai type.In a more ideal world, it would be easy to register variadic functions to the rhai engine, but this is at least a small improvement on the existing situation.